73f162075e
Embed web assets into the Go binary
...
Serve /static from embedded assets when no static path override is configured, add static route coverage, and update Docker/docs to reflect embedded-by-default behavior.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com >
2026-02-14 22:14:39 +00:00
3d4dab2359
Finalize Go-only migration, runtime hardening, and CI/container optimization
...
This commit consolidates the full repository transition to a Go-first codebase and captures the follow-up performance/reliability work completed in the same stream.
Highlights:
- Remove Python implementation and test suites (, , , ) and retire Python-specific docs/instructions.
- Move and standardize static web assets under , updating Bun/TypeScript build paths and server static resolution logic.
- Rewrite developer workflow to Makefile-first Go targets (vet/test/race/coverage/fuzz/build) and align repository guidance/docs accordingly.
- Update Docker and CI/CD for leaner artifacts:
- switch to Alpine-based multi-stage build with stripped Go binary
- install only minimal runtime deps (, )
- tighten Docker build context via
- ensure workflows build/publish the target.
- Improve runtime correctness/latency and reduce duplication:
- explicit WebSocket outbound frame typing (text vs binary) instead of payload-byte heuristics
- SSE activity fan-out outside global lock and safer subscriber lifecycle
- shared session output/snapshot helpers to reduce duplicated logic
- restart-safe channel lifecycle for Docker watcher/stats start-stop-start flows
- faster screenshot cold-start path (poll-until-ready within timeout vs fixed sleep).
- Add/expand regression coverage for the above lifecycle and helper paths.
Validation run:
- bun run build
[32mBundled 3 modules in 10ms[0m
[34mterminal.js[33m 0.68 MB [2m(entry point)[0m (Bun typecheck + bundle)
- cd go && go vet ./...
cd go && go test ./...
ok github.com/rcarmo/webterm-go-port/cmd/webterm (cached)
ok github.com/rcarmo/webterm-go-port/internal/terminalstate (cached)
ok github.com/rcarmo/webterm-go-port/webterm (cached)
cd go && go test ./webterm -coverprofile=coverage.out && go tool cover -func=coverage.out
ok github.com/rcarmo/webterm-go-port/webterm (cached) coverage: 81.0% of statements
github.com/rcarmo/webterm-go-port/webterm/cli.go:14: RunCLI 51.6%
github.com/rcarmo/webterm-go-port/webterm/config.go:25: DefaultConfig 100.0%
github.com/rcarmo/webterm-go-port/webterm/config.go:29: LoadLandingYAML 82.6%
github.com/rcarmo/webterm-go-port/webterm/config.go:70: LoadComposeManifest 76.9%
github.com/rcarmo/webterm-go-port/webterm/config.go:114: extractLabel 92.3%
github.com/rcarmo/webterm-go-port/webterm/config.go:138: asString 80.0%
github.com/rcarmo/webterm-go-port/webterm/constants.go:27: EnvBool 50.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:30: Read 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:56: NewDockerExecSession 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:72: Open 90.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:99: Start 85.7%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:119: readLoop 83.3%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:143: handleOutput 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:153: createExec 75.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:183: startExecSocket 60.7%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:219: resizeExec 83.3%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:237: Close 90.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:250: Wait 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:257: SetTerminalSize 81.8%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:274: ForceRedraw 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:281: SendBytes 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:294: SendMeta 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:298: IsRunning 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:304: GetReplayBuffer 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:308: GetScreenSnapshot 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_exec_session.go:316: UpdateConnector 80.0%
github.com/rcarmo/webterm-go-port/webterm/docker_http.go:23: DockerSocketPath 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_http.go:37: newUnixHTTPClient 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_http.go:47: sharedUnixClient 91.7%
github.com/rcarmo/webterm-go-port/webterm/docker_http.go:64: unixJSONRequest 84.2%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:33: NewDockerStatsCollector 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:47: Available 72.7%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:64: Start 80.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:78: Stop 75.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:90: AddService 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:101: RemoveService 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:115: GetCPUHistory 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:124: pollLoop 95.2%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:160: discoverContainers 65.4%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:198: pollContainer 77.8%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:223: calculateCPUPercent 69.2%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:260: RenderSparklineSVG 89.3%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:299: max 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:306: toAnyMap 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:323: toStringMap 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:331: toAnySlice 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:340: toStringSlice 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:351: toUint 91.7%
github.com/rcarmo/webterm-go-port/webterm/docker_stats.go:376: toInt 85.7%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:34: NewDockerWatcher 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:54: hasWebtermLabel 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:60: isAutoLabel 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:67: getContainerCommand 80.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:76: getContainerTheme 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:81: getContainerName 42.9%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:93: containerToSlug 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:98: addContainer 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:119: removeContainer 100.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:143: listLabeledContainers 94.1%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:168: handleEvent 80.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:202: watchEvents 85.7%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:239: ScanExisting 60.0%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:249: Start 83.3%
github.com/rcarmo/webterm-go-port/webterm/docker_watcher.go:265: Stop 81.8%
github.com/rcarmo/webterm-go-port/webterm/identity.go:12: GenerateID 94.1%
github.com/rcarmo/webterm-go-port/webterm/normalize.go:13: FilterDASequences 83.3%
github.com/rcarmo/webterm-go-port/webterm/replay.go:14: NewReplayBuffer 66.7%
github.com/rcarmo/webterm-go-port/webterm/replay.go:21: Add 100.0%
github.com/rcarmo/webterm-go-port/webterm/replay.go:43: Bytes 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:95: OnData 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go💯 OnBinary 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:105: OnMeta 0.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:107: OnClose 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:112: NewLocalServer 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:163: findStaticPath 62.5%
github.com/rcarmo/webterm-go-port/webterm/server.go:184: markRouteActivity 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:207: enqueueWSFrame 77.8%
github.com/rcarmo/webterm-go-port/webterm/server.go:233: stopWSClient 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:246: wsSender 80.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:256: createTerminalSession 66.7%
github.com/rcarmo/webterm-go-port/webterm/server.go:278: clampInt 60.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:288: parseResizePayload 88.9%
github.com/rcarmo/webterm-go-port/webterm/server.go:303: handleWebSocket 81.1%
github.com/rcarmo/webterm-go-port/webterm/server.go:425: chooseRouteForScreenshot 50.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:440: screenshotTTL 66.7%
github.com/rcarmo/webterm-go-port/webterm/server.go:457: handleScreenshot 55.7%
github.com/rcarmo/webterm-go-port/webterm/server.go:541: handleCPUSparkline 94.4%
github.com/rcarmo/webterm-go-port/webterm/server.go:566: handleEvents 76.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:602: toIntFromQuery 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:609: dashboardTiles 81.8%
github.com/rcarmo/webterm-go-port/webterm/server.go:631: handleTiles 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:636: getWSURL 65.2%
github.com/rcarmo/webterm-go-port/webterm/server.go:671: handleRoot 56.8%
github.com/rcarmo/webterm-go-port/webterm/server.go:732: htmlEscape 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:736: htmlAttrEscape 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:740: handleHealth 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:744: setupDockerFeatures 40.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:791: shutdown 62.5%
github.com/rcarmo/webterm-go-port/webterm/server.go:814: Handler 100.0%
github.com/rcarmo/webterm-go-port/webterm/server.go:829: Run 77.8%
github.com/rcarmo/webterm-go-port/webterm/session.go:31: OnData 0.0%
github.com/rcarmo/webterm-go-port/webterm/session.go:32: OnBinary 0.0%
github.com/rcarmo/webterm-go-port/webterm/session.go:33: OnMeta 0.0%
github.com/rcarmo/webterm-go-port/webterm/session.go:34: OnClose 0.0%
github.com/rcarmo/webterm-go-port/webterm/session.go:36: dispatchSessionOutput 100.0%
github.com/rcarmo/webterm-go-port/webterm/session.go:47: snapshotFromTracker 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:20: NewSessionManager 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:34: SetSessionFactory 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:40: defaultSessionFactory 87.5%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:57: splitCommand 75.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:65: shlexSplit 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:69: AddApp 87.5%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:88: RemoveApp 87.5%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:101: Apps 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:107: AppBySlug 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:114: GetDefaultApp 80.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:123: NewSession 50.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:167: OnSessionEnd 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:176: CloseAll 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:189: CloseSession 87.5%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:201: GetSession 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:207: GetSessionByRouteKey 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:217: GetSessionIDByRouteKey 100.0%
github.com/rcarmo/webterm-go-port/webterm/session_manager.go:223: GetFirstRunningSession 85.7%
github.com/rcarmo/webterm-go-port/webterm/shellsplit.go:5: shlexSplitImpl 100.0%
github.com/rcarmo/webterm-go-port/webterm/slugify.go:13: Slugify 100.0%
github.com/rcarmo/webterm-go-port/webterm/svg_exporter.go:35: RenderTerminalSVG 92.6%
github.com/rcarmo/webterm-go-port/webterm/svg_exporter.go:113: colorToHex 87.5%
github.com/rcarmo/webterm-go-port/webterm/svg_exporter.go:139: isHex 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:37: NewTerminalSession 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:49: Open 86.7%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:90: Start 85.7%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:110: readLoop 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:132: handleOutput 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:142: Close 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:160: Wait 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:167: SetTerminalSize 80.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:190: ForceRedraw 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:198: SendBytes 88.9%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:211: SendMeta 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:215: IsRunning 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:221: GetReplayBuffer 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:225: GetScreenSnapshot 100.0%
github.com/rcarmo/webterm-go-port/webterm/terminal_session.go:233: UpdateConnector 80.0%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:14: NewTwoWayMap 100.0%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:21: Set 88.9%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:36: DeleteKey 100.0%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:45: Get 100.0%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:52: GetKey 100.0%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:59: Keys 100.0%
github.com/rcarmo/webterm-go-port/webterm/twoway.go:70: UnsafeForward 100.0%
total: (statements) 81.0%
- cd go && go test -race ./...
ok github.com/rcarmo/webterm-go-port/cmd/webterm (cached)
ok github.com/rcarmo/webterm-go-port/internal/terminalstate (cached)
ok github.com/rcarmo/webterm-go-port/webterm (cached)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com >
2026-02-14 18:03:28 +00:00
10ffb9d8cc
docs: consolidate pyte patches documentation
...
Rename ink-clear-fix.md → pyte-patches.md and rewrite as a
comprehensive reference for all pyte monkeypatches:
- Patch 1: CSI S/T (SU/SD scroll) — primary ghost content fix
- Patch 2: Alternate screen buffer (DECSET 1049)
- Patch 3: Ink partial clear expansion (secondary defense)
Update README.md Known Issues to reflect the actual fix approach.
Update ARCHITECTURE.md to document alt_screen.py and pyte patching.
2026-02-06 21:24:52 +00:00
207eddc922
fix: implement CSI S/T (scroll up/down) to fix ghost content in screenshots
...
pyte 0.8.2 does not handle CSI S (SU — Scroll Up) or CSI T (SD —
Scroll Down). When TERM=xterm-256color, tmux sends CSI n S for bulk
scrolling instead of DECSTBM+index. pyte silently ignored these
sequences, leaving old content in the screen buffer — visible as
ghost content in SVG screenshots.
Fix: monkeypatch pyte's CSI dispatch tables to map S→scroll_up and
T→scroll_down, and implement both methods on AltScreen with proper
scroll-region (DECSTBM) support.
Adds 6 tests for SU/SD functionality.
2026-02-06 21:21:57 +00:00
3ba8c7f352
fix: expand Ink partial clears to prevent ghost content in screenshots
...
Ink (React CLI framework) clears its output using repeated EL2+CUU1
sequences, one per previously-drawn line. When /clear resets Ink's
internal line counter, the next frame only erases a few lines instead
of the full previous output. In a real terminal the old content is in
scrollback and invisible, but pyte's fixed-size screen retains it,
producing ghost content (e.g. duplicated prompts) in SVG screenshots.
Added AltScreen.expand_clear_sequences() which detects runs of 3+
EL2+CUU1 pairs that don't reach row 0 and extends them to erase all
lines up to the top of the screen. Both DockerExecSession and
TerminalSession call this before feeding data to pyte.
Also made on_session_end() idempotent (contextlib.suppress KeyError)
to prevent a race when close_session() and natural session exit both
call it.
Added docs/ink-clear-fix.md with root cause analysis, byte-level
explanation, and reproduction script.
2026-02-06 20:00:09 +00:00
003f0c4613
docs: add explanation of tmux DA response filtering fix
...
Documents the investigation and fix for the '1;10;0c' display issue
that occurred when refreshing browser sessions running tmux.
2026-01-29 20:30:38 +00:00
b4d7f2e98a
Bump minor version and update ghostty-web
2026-01-28 16:13:08 +00:00
0fad9e7353
docs: update for v1.0.0 release with ghostty-web
...
- Update ARCHITECTURE.md with ghostty-web details and native theme support
- Update ROADMAP.md marking migration complete
- Note patched ghostty-web fork from rcarmo/ghostty-web
- Document 11 built-in themes, IME support, smaller bundle size
- Bump version to 1.0.0
2026-01-28 11:20:06 +00:00
13912a18f8
Update docs/ARCHITECTURE.md and docs/ROADMAP.md for ghostty-web migration
2026-01-28 07:28:46 +00:00
d91d1b0ec6
Detail pyte vs GoPyte capture features and gaps
2026-01-27 13:58:56 +00:00
245849ba9f
Deepen pyte vs GoPyte capture requirements
2026-01-26 14:28:04 +00:00
9d45610f06
Expand pyte vs GoPyte comparison for capture requirements
2026-01-26 11:42:49 +00:00
918df259f6
Expand pyte vs GoPyte comparison and add alternatives
2026-01-26 11:26:14 +00:00
12baa6ac27
Add pyte vs gopyte comparison to ROADMAP
2026-01-26 10:57:49 +00:00
eb60f99125
Add Go reimplementation analysis to ROADMAP
...
Detailed 8-phase implementation plan for a Go version:
- Component mapping with library recommendations
- ~13 day effort estimate
- File structure and build targets
- Docker image goal: ~20MB vs ~200MB Python
- Decision criteria for when to use Go vs Python
2026-01-26 08:42:25 +00:00
c02a8f9f02
Update ROADMAP.md with completed status
2026-01-25 12:53:17 +00:00
1bc0cd177b
Update documentation for xterm.js 6.0 migration
...
- README: Add scrollback feature, frontend dev instructions, update related projects
- ARCHITECTURE: Document xterm.js bundling decision, update file structure
2026-01-25 12:50:23 +00:00
67831a50ee
Include pre-built terminal.js bundle in repo
...
Users can pip install directly from git URL without needing Bun.
Developers regenerate with: make bundle
2026-01-25 12:49:08 +00:00
6f624b8565
Replace textual-serve with direct xterm.js 6.0 bundle
...
- Add package.json with @xterm/xterm 6.0 and all addons
- Create terminal.ts client with WebSocket protocol support
- Bundle with Bun (bun run build -> terminal.js)
- Remove textual-serve dependency from pyproject.toml
- Remove canvas monkey-patch workaround (no longer needed)
- Add scrollback support (configurable via data-scrollback)
- Update static file routing to serve from /static/
- Add Makefile targets: bundle, bundle-watch, bundle-clean
- Update tests for new static path structure
Benefits:
- Full control over xterm.js configuration
- Scrollback history now works (default 1000 lines)
- Custom font family without workarounds
- Smaller footprint (no unused Roboto Mono fonts)
- Latest xterm.js 6.0 features available
2026-01-25 12:45:50 +00:00
5512c84ae1
screenshot
2026-01-24 22:14:00 +00:00
80e82454d7
Fix ASCII diagram box alignment in ARCHITECTURE.md
...
Ensure all lines have consistent length and box borders align properly.
2026-01-24 20:38:50 +00:00
ba5ff120c9
Fix ASCII diagram alignment in ARCHITECTURE.md
2026-01-24 20:29:32 +00:00
45645ab724
Add ARCHITECTURE.md documentation
...
Comprehensive architecture document covering:
- System overview with ASCII diagram
- Core components and their responsibilities
- Data flow for terminal I/O, screenshots, and SSE
- Session lifecycle
- WebSocket protocol specification
- API endpoints reference
- Key design decisions and rationale
- File structure overview
2026-01-24 20:28:56 +00:00
a0e31d43fd
merge
2026-01-21 23:53:57 +00:00
GitHub Copilot