Fix bug causing too-aggressive prediction (showing part of passwords)

This commit is contained in:
Keith Winstein
2012-02-26 05:20:16 -05:00
parent dae8734c9d
commit b2abc0d9b6
+4
View File
@@ -83,6 +83,10 @@ Validity ConditionalOverlayCell::get_validity( const Framebuffer &fb, int row,
return CorrectNoCredit; return CorrectNoCredit;
} }
if ( replacement.is_blank() ) { /* too easy for this to trigger falsely */
return CorrectNoCredit;
}
if ( (current.contents == replacement.contents) if ( (current.contents == replacement.contents)
|| (current.is_blank() && replacement.is_blank()) ) { || (current.is_blank() && replacement.is_blank()) ) {
BOOST_AUTO( it, find_if( original_contents.begin(), original_contents.end(), BOOST_AUTO( it, find_if( original_contents.begin(), original_contents.end(),