From b2abc0d9b66f360214c5db1d0547c73c3adea365 Mon Sep 17 00:00:00 2001 From: Keith Winstein Date: Sun, 26 Feb 2012 05:20:16 -0500 Subject: [PATCH] Fix bug causing too-aggressive prediction (showing part of passwords) --- src/frontend/terminaloverlay.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/frontend/terminaloverlay.cc b/src/frontend/terminaloverlay.cc index 2e6b2c1..86eaaa7 100644 --- a/src/frontend/terminaloverlay.cc +++ b/src/frontend/terminaloverlay.cc @@ -83,6 +83,10 @@ Validity ConditionalOverlayCell::get_validity( const Framebuffer &fb, int row, return CorrectNoCredit; } + if ( replacement.is_blank() ) { /* too easy for this to trigger falsely */ + return CorrectNoCredit; + } + if ( (current.contents == replacement.contents) || (current.is_blank() && replacement.is_blank()) ) { BOOST_AUTO( it, find_if( original_contents.begin(), original_contents.end(),