izackp/mosh
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop the -pedantic flag from CXX_FLAGS

Browse Source 
Abseil uses certain compiler extensions intentionally (see abseil/abseil-cpp#157) so it triggers multiple warnings enabled by -pedantic (-Wnullability-extension, -Wgcc-compat, -Wvariadic-macro-arguments-omitted at a minimum) as seen in #1373.
This commit is contained in:
Eric Dorland
2026-02-23 01:05:36 -05:00
committed by Alex Chernyakhovsky
parent 59e3aa96c7
commit 64ce9aad9a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
configure.ac
+3 -3
View File
@@ -40,7 +40,7 @@ AC_ARG_ENABLE([compile-warnings],
;; ;;
maximum) maximum)
WARNING_CXXFLAGS="-Wall" WARNING_CXXFLAGS="-Wall"
PICKY_CXXFLAGS="-Wextra -pedantic -Wno-long-long -Weffc++ -Wmissing-declarations" PICKY_CXXFLAGS="-Wextra -Wno-long-long -Weffc++ -Wmissing-declarations"
;; ;;
error) error)
# remove -Wno-c++17-extensions once protocolbuffers/protobuf#9181 is # remove -Wno-c++17-extensions once protocolbuffers/protobuf#9181 is
@@ -48,11 +48,11 @@ AC_ARG_ENABLE([compile-warnings],
# remove -Wno-unused-parameter once # remove -Wno-unused-parameter once
# protocolbuffers/protobuf#10357 is resolved # protocolbuffers/protobuf#10357 is resolved
WARNING_CXXFLAGS="-Wall -Werror -Wno-c++17-extensions" WARNING_CXXFLAGS="-Wall -Werror -Wno-c++17-extensions"
PICKY_CXXFLAGS="-Wextra -pedantic -Wno-long-long -Weffc++ -Wmissing-declarations -Wno-unused-parameter" PICKY_CXXFLAGS="-Wextra -Wno-long-long -Weffc++ -Wmissing-declarations -Wno-unused-parameter"
;; ;;
distcheck) distcheck)
WARNING_CXXFLAGS="-Wall -Werror" WARNING_CXXFLAGS="-Wall -Werror"
PICKY_CXXFLAGS="-Wextra -pedantic -Wno-long-long -Weffc++ -Wmissing-declarations" PICKY_CXXFLAGS="-Wextra -Wno-long-long -Weffc++ -Wmissing-declarations"
AX_CHECK_COMPILE_FLAG([-Wno-error=unused-parameter], AX_CHECK_COMPILE_FLAG([-Wno-error=unused-parameter],
[PICKY_CXXFLAGS="$PICKY_CXXFLAGS -Wno-error=unused-parameter"], [], [-Werror]) [PICKY_CXXFLAGS="$PICKY_CXXFLAGS -Wno-error=unused-parameter"], [], [-Werror])
AX_CHECK_COMPILE_FLAG([-Wno-error=c++11-extensions], AX_CHECK_COMPILE_FLAG([-Wno-error=c++11-extensions],