From 64ce9aad9a8962083298f88c7823409e58997972 Mon Sep 17 00:00:00 2001 From: Eric Dorland Date: Mon, 23 Feb 2026 01:05:36 -0500 Subject: [PATCH] Drop the -pedantic flag from CXX_FLAGS Abseil uses certain compiler extensions intentionally (see abseil/abseil-cpp#157) so it triggers multiple warnings enabled by -pedantic (-Wnullability-extension, -Wgcc-compat, -Wvariadic-macro-arguments-omitted at a minimum) as seen in #1373. --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 6881a0e..f75e75a 100644 --- a/configure.ac +++ b/configure.ac @@ -40,7 +40,7 @@ AC_ARG_ENABLE([compile-warnings], ;; maximum) WARNING_CXXFLAGS="-Wall" - PICKY_CXXFLAGS="-Wextra -pedantic -Wno-long-long -Weffc++ -Wmissing-declarations" + PICKY_CXXFLAGS="-Wextra -Wno-long-long -Weffc++ -Wmissing-declarations" ;; error) # remove -Wno-c++17-extensions once protocolbuffers/protobuf#9181 is @@ -48,11 +48,11 @@ AC_ARG_ENABLE([compile-warnings], # remove -Wno-unused-parameter once # protocolbuffers/protobuf#10357 is resolved WARNING_CXXFLAGS="-Wall -Werror -Wno-c++17-extensions" - PICKY_CXXFLAGS="-Wextra -pedantic -Wno-long-long -Weffc++ -Wmissing-declarations -Wno-unused-parameter" + PICKY_CXXFLAGS="-Wextra -Wno-long-long -Weffc++ -Wmissing-declarations -Wno-unused-parameter" ;; distcheck) WARNING_CXXFLAGS="-Wall -Werror" - PICKY_CXXFLAGS="-Wextra -pedantic -Wno-long-long -Weffc++ -Wmissing-declarations" + PICKY_CXXFLAGS="-Wextra -Wno-long-long -Weffc++ -Wmissing-declarations" AX_CHECK_COMPILE_FLAG([-Wno-error=unused-parameter], [PICKY_CXXFLAGS="$PICKY_CXXFLAGS -Wno-error=unused-parameter"], [], [-Werror]) AX_CHECK_COMPILE_FLAG([-Wno-error=c++11-extensions],