refactor: normalize logging to use %-style formatting

Convert f-string logging to lazy %-style interpolation throughout:
- session_manager.py
- cli.py
- terminal_session.py

This follows Python logging best practices for performance (lazy
evaluation) and consistency across the codebase.

Addresses REFACTORING.md item about normalizing logging style.
This commit is contained in:
GitHub Copilot
2026-01-24 10:26:53 +00:00
parent 0086cf76b0
commit ea78ba7ff2
3 changed files with 14 additions and 14 deletions
+4 -4
View File
@@ -54,7 +54,7 @@ class TerminalSession(Session):
yield "command", self.command
async def open(self, width: int = 80, height: int = 24) -> None:
log.info(f"Opening terminal session {self.session_id} with command: {self.command}")
log.info("Opening terminal session %s with command: %s", self.session_id, self.command)
pid, master_fd = pty.fork()
self.pid = pid
self.master_fd = master_fd
@@ -78,7 +78,7 @@ class TerminalSession(Session):
os.close(master_fd)
self.master_fd = None
raise
log.debug(f"Terminal session {self.session_id} opened successfully")
log.debug("Terminal session %s opened successfully", self.session_id)
def _set_terminal_size(self, width: int, height: int) -> None:
buf = array.array("h", [height, width, 0, 0])
@@ -106,7 +106,7 @@ class TerminalSession(Session):
def update_connector(self, connector: SessionConnector) -> None:
"""Update the connector for reconnection without restarting the session."""
self._connector = connector
log.debug(f"Updated connector for session {self.session_id}")
log.debug("Updated connector for session %s", self.session_id)
async def start(self, connector: SessionConnector) -> asyncio.Task:
self._connector = connector
@@ -158,7 +158,7 @@ class TerminalSession(Session):
except ProcessLookupError:
pass # Process already gone
except Exception as e:
log.warning(f"Error closing terminal session {self.session_id}: {e}")
log.warning("Error closing terminal session %s: %s", self.session_id, e)
async def wait(self) -> None:
if self._task is not None: