Fix proposeDimensions error: skip call when terminal not ready

Browse Source

When terminal is not ready after max attempts, go directly to fallback
dimensions instead of falling through to call proposeDimensions() which
throws 'viewport.scrollBarWidth' TypeError.

Root cause: FitAddon.proposeDimensions() checks _renderService.dimensions
before accessing viewport.scrollBarWidth, but dimensions can be valid
while viewport is still undefined during terminal initialization.

...

This commit is contained in:

GitHub Copilot

2026-01-28 00:42:23 +00:00

parent 8ee6f2d605

commit 712cc72911

3 changed files with 9 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

src/textual_webterm/static/js/terminal.js

+1 -1

File diff suppressed because one or more lines are too long