Add CPU sparkline to dashboard in compose mode
- New docker_stats.py module reads container stats from Docker socket using only asyncio + stdlib (no new dependencies) - Calculates CPU % from delta of cpu_usage and system_cpu_usage - Maintains ring buffer of last 30 CPU readings per container - render_sparkline_svg() generates mini SVG chart from history - DockerStatsCollector polls containers every 2 seconds - New /cpu-sparkline.svg endpoint serves sparkline for a container - Dashboard shows sparkline in tile header next to container name - Only active in compose mode (--compose-manifest flag) - Graceful degradation if Docker socket unavailable Bump version to 0.1.17
This commit is contained in:
GitHub Copilot
@@ -0,0 +1,209 @@
|
||||
"""Tests for docker_stats module."""
|
||||
|
||||
import pytest
|
||||
from unittest.mock import MagicMock, patch, AsyncMock
|
||||
from textual_webterm.docker_stats import (
|
||||
DockerStatsCollector,
|
||||
render_sparkline_svg,
|
||||
STATS_HISTORY_SIZE,
|
||||
)
|
||||
|
||||
|
||||
class TestRenderSparklineSvg:
|
||||
"""Tests for SVG sparkline rendering."""
|
||||
|
||||
def test_empty_values(self):
|
||||
"""Empty values produce empty SVG."""
|
||||
svg = render_sparkline_svg([])
|
||||
assert "<svg" in svg
|
||||
assert "width=" in svg
|
||||
assert "polygon" not in svg # No data to draw
|
||||
|
||||
def test_single_value(self):
|
||||
"""Single value renders correctly."""
|
||||
svg = render_sparkline_svg([50.0])
|
||||
assert "<svg" in svg
|
||||
assert "polygon" in svg
|
||||
assert "polyline" in svg
|
||||
|
||||
def test_multiple_values(self):
|
||||
"""Multiple values render as sparkline."""
|
||||
values = [10.0, 50.0, 30.0, 80.0, 20.0]
|
||||
svg = render_sparkline_svg(values)
|
||||
assert "<svg" in svg
|
||||
assert "polygon" in svg
|
||||
assert "polyline" in svg
|
||||
|
||||
def test_custom_dimensions(self):
|
||||
"""Custom width/height are applied."""
|
||||
svg = render_sparkline_svg([50.0], width=200, height=40)
|
||||
assert 'width="200"' in svg
|
||||
assert 'height="40"' in svg
|
||||
|
||||
def test_custom_colors(self):
|
||||
"""Custom colors are applied."""
|
||||
svg = render_sparkline_svg(
|
||||
[50.0],
|
||||
stroke_color="#ff0000",
|
||||
fill_color="rgba(255, 0, 0, 0.3)",
|
||||
)
|
||||
assert "#ff0000" in svg
|
||||
assert "rgba(255, 0, 0, 0.3)" in svg
|
||||
|
||||
def test_zero_values(self):
|
||||
"""All zero values don't cause division errors."""
|
||||
svg = render_sparkline_svg([0.0, 0.0, 0.0])
|
||||
assert "<svg" in svg
|
||||
|
||||
def test_high_values(self):
|
||||
"""High CPU values (100%+) render correctly."""
|
||||
svg = render_sparkline_svg([100.0, 150.0, 200.0])
|
||||
assert "<svg" in svg
|
||||
|
||||
|
||||
class TestDockerStatsCollector:
|
||||
"""Tests for Docker stats collector."""
|
||||
|
||||
def test_available_checks_socket(self, tmp_path):
|
||||
"""available property checks socket existence."""
|
||||
socket_path = tmp_path / "docker.sock"
|
||||
collector = DockerStatsCollector(str(socket_path))
|
||||
assert collector.available is False
|
||||
|
||||
socket_path.touch()
|
||||
assert collector.available is True
|
||||
|
||||
def test_get_cpu_history_empty(self):
|
||||
"""Empty history returns empty list."""
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
assert collector.get_cpu_history("container1") == []
|
||||
|
||||
def test_get_cpu_history_with_data(self):
|
||||
"""CPU history returns stored values."""
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
collector._cpu_history["test"] = [10.0, 20.0, 30.0]
|
||||
# get_cpu_history converts deque to list
|
||||
collector._cpu_history["test"] = list.__new__(list)
|
||||
collector._cpu_history["test"].extend([10.0, 20.0, 30.0])
|
||||
|
||||
history = collector.get_cpu_history("test")
|
||||
assert history == [10.0, 20.0, 30.0]
|
||||
|
||||
def test_calculate_cpu_percent(self):
|
||||
"""CPU percentage calculation."""
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
|
||||
cpu_stats = {
|
||||
"cpu_usage": {"total_usage": 1000000000},
|
||||
"system_cpu_usage": 10000000000,
|
||||
"online_cpus": 4,
|
||||
}
|
||||
precpu_stats = {
|
||||
"cpu_usage": {"total_usage": 500000000},
|
||||
"system_cpu_usage": 5000000000,
|
||||
}
|
||||
|
||||
result = collector._calculate_cpu_percent("test", cpu_stats, precpu_stats)
|
||||
assert result is not None
|
||||
assert 0 <= result <= 400 # 4 CPUs max
|
||||
|
||||
def test_calculate_cpu_percent_zero_delta(self):
|
||||
"""Zero system delta returns None."""
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
|
||||
cpu_stats = {
|
||||
"cpu_usage": {"total_usage": 1000},
|
||||
"system_cpu_usage": 1000,
|
||||
"online_cpus": 1,
|
||||
}
|
||||
precpu_stats = {
|
||||
"cpu_usage": {"total_usage": 1000},
|
||||
"system_cpu_usage": 1000,
|
||||
}
|
||||
|
||||
result = collector._calculate_cpu_percent("test", cpu_stats, precpu_stats)
|
||||
assert result is None
|
||||
|
||||
def test_start_without_socket(self, tmp_path):
|
||||
"""Start does nothing if socket not available."""
|
||||
collector = DockerStatsCollector(str(tmp_path / "nonexistent.sock"))
|
||||
collector.start(["container1"])
|
||||
assert collector._running is False
|
||||
assert collector._task is None
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_stop_without_start(self):
|
||||
"""Stop is safe to call without start."""
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
await collector.stop() # Should not raise
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_make_request_no_socket(self):
|
||||
"""Request returns None if socket unavailable."""
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
result = await collector._make_request("/test")
|
||||
assert result is None
|
||||
|
||||
def test_cpu_history_max_size(self):
|
||||
"""CPU history respects max size."""
|
||||
from collections import deque
|
||||
|
||||
collector = DockerStatsCollector("/nonexistent")
|
||||
collector._cpu_history["test"] = deque(maxlen=STATS_HISTORY_SIZE)
|
||||
|
||||
# Add more than max entries
|
||||
for i in range(STATS_HISTORY_SIZE + 10):
|
||||
collector._cpu_history["test"].append(float(i))
|
||||
|
||||
assert len(collector._cpu_history["test"]) == STATS_HISTORY_SIZE
|
||||
|
||||
|
||||
class TestLocalServerSparklineEndpoint:
|
||||
"""Tests for the CPU sparkline endpoint in LocalServer."""
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_sparkline_endpoint_missing_container(self):
|
||||
"""Missing container param returns 400."""
|
||||
from aiohttp.web import HTTPBadRequest
|
||||
from textual_webterm.local_server import LocalServer
|
||||
from textual_webterm.config import Config
|
||||
|
||||
server = LocalServer("./", Config(), compose_mode=True)
|
||||
|
||||
request = MagicMock()
|
||||
request.query = {}
|
||||
|
||||
with pytest.raises(HTTPBadRequest):
|
||||
await server._handle_cpu_sparkline(request)
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_sparkline_endpoint_returns_svg(self):
|
||||
"""Sparkline endpoint returns SVG."""
|
||||
from textual_webterm.local_server import LocalServer
|
||||
from textual_webterm.config import Config
|
||||
|
||||
server = LocalServer("./", Config(), compose_mode=True)
|
||||
|
||||
request = MagicMock()
|
||||
request.query = {"container": "test", "width": "80", "height": "20"}
|
||||
|
||||
response = await server._handle_cpu_sparkline(request)
|
||||
assert response.content_type == "image/svg+xml"
|
||||
assert "<svg" in response.text
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_sparkline_with_stats_collector(self):
|
||||
"""Sparkline uses stats collector data when available."""
|
||||
from textual_webterm.local_server import LocalServer
|
||||
from textual_webterm.config import Config
|
||||
|
||||
server = LocalServer("./", Config(), compose_mode=True)
|
||||
server._docker_stats = MagicMock()
|
||||
server._docker_stats.get_cpu_history.return_value = [10.0, 20.0, 30.0]
|
||||
|
||||
request = MagicMock()
|
||||
request.query = {"container": "test"}
|
||||
|
||||
response = await server._handle_cpu_sparkline(request)
|
||||
server._docker_stats.get_cpu_history.assert_called_once_with("test")
|
||||
assert "<svg" in response.text
|
||||
Reference in New Issue
Block a user