From 7e5d6e3d40653efb30c18ca1b2e92bbe81f4dc1f Mon Sep 17 00:00:00 2001 From: banteg <4562643+banteg@users.noreply.github.com> Date: Fri, 2 Jan 2026 14:25:53 +0400 Subject: [PATCH] docs: align runner docs with current API --- docs/developing.md | 2 +- docs/runner/codex/codex-takopi-events.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/developing.md b/docs/developing.md index f856acb..9f314b9 100644 --- a/docs/developing.md +++ b/docs/developing.md @@ -90,7 +90,7 @@ The orchestrator module containing: - Per-resume locks (WeakValueDictionary) prevent concurrent resumes of the same session - Event delivery uses a single internal queue to preserve order without per-event tasks - Stderr is drained into a bounded tail (debug logging only) -- Event callbacks must not raise; callback errors abort the run +- Translation errors abort the run; keep event normalization defensive ### `model.py` / `runner.py` - Core domain types diff --git a/docs/runner/codex/codex-takopi-events.md b/docs/runner/codex/codex-takopi-events.md index 8fc6b44..c4035d0 100644 --- a/docs/runner/codex/codex-takopi-events.md +++ b/docs/runner/codex/codex-takopi-events.md @@ -69,7 +69,7 @@ From the bridge/runner point of view: 1. **Bridge receives Telegram prompt** 2. Bridge tries to extract a resume line (`codex resume `) from the message/reply (runner-owned parsing). -3. Bridge calls `runner.run(prompt, resumeTokenOrNone, on_event=...)` +3. Bridge calls `runner.run(prompt, resumeTokenOrNone)` 4. Codex runner spawns `codex exec --json ...` and reads JSONL line-by-line. 5. The *first moment the runner can know thread identity* is: @@ -350,7 +350,7 @@ did_emit_started = False did_emit_completed = False turn_index = 0 -def emit(evt): on_event(evt) +def emit(evt): yield evt # emit to the output event stream for line in codex_jsonl_stream: t = line["type"]