Split src/crypto/ocb.cc into two files – one containing the AES-OCB
implementation backed by OpenSSL, and the other containing
implementations backed by Apple Common Crypto and Nettle. This paves the
way for a new OpenSSL implementation that uses OpenSSL 1.1’s OCB support
directly, rather than one that merely uses OpenSSL to provide the
underlying block cipher.
Remove support for rijndael-alg-fst.c and compiler-provided AES
intrinsics, since they’re not in use anymore. (Mosh can still use
hardware-accelerated AES if it’s available; it just now relies
exclusively on the underlying cryptography library to accelerate AES if
possible.)
Update the build system to conditionally compile in either
ocb_openssl.cc or ocb_internal.cc, depending on which cryptography
library you pass to ./configure.
To make this commit easy to audit, ocb_openssl.cc and ocb_internal.cc
are trivially diffable against ocb.cc (now deleted). Expected diffs
consist of a copyright notice update, a preprocessor check to ensure the
appropriate cryptography implementation has been selected, and deletions
to remove code that’s no longer in use. This does mean a substantial
amount of code is duplicated between ocb_openssl.cc and ocb_internal.cc;
however, ocb_openssl.cc should be completely replaced soon, so it won’t
be an issue in the long term.
Bug: https://github.com/mobile-shell/mosh/issues/1174
The format of debian/changelog is very rigid as it is parsed by the
build tools to determine the version number and other information.
The version number must use ~ so that 1.3.0 is considered greater than
1.3.0~rc2 for upgrades, and there must be a Debian release number like
-1 because this is not a Debian-native package. Finally, the default
urgency is medium these days.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
By informing Debhelper that the mosh wrapper script only uses modules in
perl-base (dh_perl -d), we cause ${perl:Depends} to change from ‘perl’
to empty, which silences this build warning:
dpkg-gencontrol: warning: package mosh: unused substitution variable ${perl:Depends}
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This improves the completion, as suggested in
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782169>,
and moves the completion from `/etc/bash_completion.d/mosh` to
`/usr/share/bash-completion/completions/mosh` as recommended by
lintian in its `package-install-into-obsolete-dir` check.
Closes#628.
Signed-off-by: John Hood <cgull@glup.org>
Benjamin Barenblat