Commit Graph

658 Commits

Author SHA1 Message Date
John Hood 71829ff631 unicode-later-combining.test: Document slightly. 2018-08-29 22:44:04 -04:00
John Hood fecd4ee29b Some more namespace hygiene for "using decl;". 2018-08-15 19:28:38 -04:00
John Hood 756f4f8e98 Remove "using namespace std;". 2018-08-15 19:27:23 -04:00
John Hood fb23168ed9 Always use std::min, std::max. 2018-08-15 19:26:27 -04:00
John Hood e5f8a826ef Fix bind(2) being misinterpreted as std::bind() with libc++7 on FreeBSD.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230624
2018-08-15 01:11:48 -04:00
John Hood 4aff80b872 Fix more inappropriate const_iterator usage. 2018-08-03 19:39:08 -04:00
John Hood 9a606c2f3d src/statesync/completeterminal.cc: fix bad iterator type 2018-08-03 17:32:07 -04:00
John Hood 8ac80db419 C++03 bound functions are not available in C++17; remove
This makes me a little sad, it's time to move to C++11 or greater.
2018-08-03 16:13:47 -04:00
John Hood 5cdbad68b8 Ignore select() errors on Travis/MacOS. 2018-08-03 15:16:55 -04:00
John Hood 3ea9e3e5a4 mosh-server: improve error logging
Also stop using _exit(), believed unnecessary now with proper stdio
flushing.
2018-08-03 15:16:55 -04:00
John Hood 2a5b5410b2 Fix gcc8 snprintf truncation warning. 2018-04-11 18:10:59 -04:00
Anders Kaseorg 10dca75fb2 Type Select::got_signal as volatile sig_atomic_t
Fixes #634.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-01-18 19:25:05 -05:00
Michael Jarvis 21d5dca682 Use HAVE_UTEMPTER instead of HAVE_UPTEMPTER
Fix typo for issue #942:
- mosh-server incorrectly reports detached session in utmp/wtmp
2017-11-21 06:05:33 -06:00
John Hood 7cd4312dae Construct socket name correctly for tmux_check()
In moving this function from e2e-test, I forgot that it depends on a
variable set there.
2017-11-08 19:50:35 -05:00
John Hood cbca234b38 Add a separate test for BCE
This test is properly gated on tmux 2.4.
2017-11-08 19:50:35 -05:00
John Hood 968d56f885 Revert "Extend true color test to include background color erase."
This reverts commit aa96fc867f.

tmux doesn't support BCE until 2.4, so this change fails on 2.3.
2017-11-07 23:14:42 -05:00
John Hood aa96fc867f Extend true color test to include background color erase. 2017-11-06 18:38:54 -05:00
John Hood fa9335f737 Fix issue with incorrect true-color background erase colors. 2017-11-06 18:07:54 -05:00
John Hood 88bb01a50a Make Renditions::sgr() more compact in both code and output. 2017-11-06 10:28:10 -05:00
John Hood ce7ba37ad4 Overlays were getting set to the wrong colors. Fix. 2017-11-06 09:30:57 -05:00
Tom Judge ab31b0f271 Add syslog logging of connections
Log connection change events to syslog in the auth log, logging the PID,
username and remote host.

Also log session begin and end.

Co-Authored-By: John Hood <cgull@glup.org>
2017-11-05 11:54:43 -05:00
John Hood e8331437d3 Minor SGR printf type signedness fixes. 2017-11-04 14:37:11 -04:00
John Hood cf493da7b4 Make Terminal::Renditions smaller, and its members private. 2017-11-04 14:37:11 -04:00
John Hood 0ec85b508e Check tmux version for truecolor test. 2017-11-04 14:37:11 -04:00
Kang.Jianbin 96b5027d9e Add emulation-attributes test for true color. 2017-10-29 20:20:03 -04:00
Kang.Jianbin 6cfa4aef59 Add true color support.
Implement true color support define in:
https://en.wikipedia.org/wiki/ANSI_escape_code

The sequence is:
ESC[ … 38;2;;; … m Select RGB foreground color
ESC[ … 48;2;;; … m Select RGB background color
2017-10-29 20:20:03 -04:00
John Hood befdb96ad1 Fix a minor uninitialized-variable warning. 2017-08-23 16:21:53 -04:00
John Hood f3fa4211a2 Always use non-blocking sockets for recvmsg() 2017-08-23 15:09:43 -04:00
John Hood b11d524bb7 Restore asserts and error handling
A couple of them got improved out of existence.
2017-08-23 15:09:43 -04:00
Keith Winstein 790b479f8a terminalframebuffer.cc: ignore unknown renditions
(revert assert(false) added by 4835dcf)
(fixes #918)
2017-08-17 13:14:52 -07:00
John Hood 6f9de49c27 Safeguard tmux sanity check. 2017-08-11 12:59:39 -04:00
John Hood a40b67691a Remove various assert(constant) calls
These cause warnings from static checkers, and seem to lead to spurious
GCC7 -Wmaybe-uninitialized.
2017-08-06 23:12:05 -04:00
John Hood 93daa5ac3b Fix Debian GCC7 FTBFS: remove default constructors 2017-08-06 23:09:07 -04:00
John Hood 6ebc795124 Remove an unnecessary conditional. 2017-08-06 22:22:35 -04:00
John Hood 9663edb7c7 Do not set function parameters. 2017-08-06 22:22:32 -04:00
John Hood 2b3034b320 Remove private static class methods. 2017-08-06 22:22:29 -04:00
John Hood 4835dcf5ee Various switch statement fixes. 2017-08-06 22:22:25 -04:00
John Hood 3346419724 Remove excessive parentheses
There are many more.
2017-08-06 22:22:20 -04:00
John Hood 1ae23b4dcc Prefer early exit/break to large conditional blocks.
Some of these are large and contain smaller unrelated refactors.
2017-08-06 22:22:09 -04:00
John Hood b1a6f7c144 Eliminate unnecessary, trailing else conditional blocks. 2017-08-06 22:22:05 -04:00
John Hood 43785eb820 Collapse nested conditionals. 2017-08-06 22:21:56 -04:00
John Hood 8ca8a54e11 Split a long printf format string. 2017-08-06 22:21:38 -04:00
Anders Kaseorg 271e8ba318 Remove unused Action::operator==
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-08-02 22:59:42 -04:00
John Hood 2b724d5868 Simplify some conditionals in terminaloverlay.cc. 2017-08-02 22:56:19 -04:00
John Hood 42d2b5d029 Use shared_ptr and references for Actions.
This slows terminal emulation slightly.
2017-08-02 22:07:02 -04:00
John Hood c6c7f09954 Deref a shared pointer in a per-byte loop 2017-08-02 22:07:02 -04:00
John Hood 8f68400c13 Convert new/delete to shared_ptr. 2017-08-02 22:07:02 -04:00
John Hood eef77fd5a5 Convert strdup/free to string 2017-08-02 22:07:02 -04:00
John Hood 6321b1d9c5 Remove redundant malloc/free 2017-08-02 22:07:02 -04:00
John Hood 54ac38bfd8 remove unneeded new/delete in Compressor 2017-08-02 22:07:02 -04:00