Commit Graph

682 Commits

Author SHA1 Message Date
John Hood 654f269917 Make tests detect UTF-8 locale with a helper executable
This uses the same utility function that mosh-client/mosh-server do.
This resolves portability issues with the 'locale' command.
This fixes OpenBSD 6.0 and probably Haiku builds.
2017-04-24 22:38:47 -04:00
Jérémie Courrèges-Anglas c0bf8053b2 Remove deprecated pledge("ioctl")
Unbreaks mosh on recent (> 2017/03/18) OpenBSD systems.
2017-03-20 09:54:33 -04:00
John Hood 0fc950bd8a Ensure a UTF-8 locale is available for tests
Fixes Debian sid schroot build.

Also add build deps required for full testing:
tmux,  less (for window-resize.test)
2017-03-01 23:16:26 -05:00
John Hood 2e816205f7 window-resize.test: use a known-present file
/etc/services may not be present in a Debian sid schroot.
Also make $srcdir available to test scripts.
2017-03-01 23:16:26 -05:00
John Hood 1cad191b10 emulation-attributes.test: fix vt100 test failure
The failure only occurs in a Debian Sid schroot environment.
2017-03-01 23:16:26 -05:00
John Hood 936ee83d29 emulation-attributes.test: fix indentation 2017-03-01 23:16:26 -05:00
Keith Winstein da206f621c src/tests/.gitignore: add inpty 2017-02-06 23:32:32 -08:00
John Hood c1d85f04fc Eliminate dead code to placate GCC 7's -Wformat-truncation. 2017-01-31 23:08:03 -05:00
John Hood a993c83632 Handle GCC 7's new -Wimplicit-fallthrough. 2017-01-31 22:12:27 -05:00
Carlos Cabanero 0ceb4f26f4 Memory Alignment issues on ARM processors
Unaligned data on ARM architectures do not perform efficiently unaligned
memory access, and in the case of ARMv7 and iOS it completely breaks. The OCB
algorithm dereferences a uint64x2_t pointer, and is replaced by a
memcpy to avoid penalties when trying to align it.

More info https://brewx.qualcomm.com/bws/content/gi/common/appseng/en/knowledgebase/docs/kb95.html
2017-01-05 00:14:36 -05:00
John Hood ba5f33fd76 Do clock_gettime() weak symbol check only on OS X/iOS 2016-12-29 23:46:00 -05:00
John Hood b2eac32ebc Try multiple clock sources at runtime. 2016-12-29 15:10:06 -05:00
John Hood 278fd12ec1 More print-to-pipe error checking in tests. 2016-11-29 22:31:33 -05:00
John Hood 60c5b022f8 Check for assertion failures while testing. 2016-11-29 22:30:25 -05:00
John Hood bb54325dc9 s/geteuid/getuid/ for correct user lookups
Addresses an issue mentioned in #193.
2016-11-23 17:03:45 -05:00
John Hood 8fcfb3a587 Fix Coverity "missing move operator" (copy to rvalue).
Also makes this bit of code more readable, but the overall handling of
Unicode characters in Actions and Transitions is messy, and may get
reworked later.
2016-11-20 01:27:51 -05:00
John Hood 24eb5a7544 Remove a Network::Exception that isn't one.
Code smell pointed out by Coverity.
2016-11-19 21:11:04 -05:00
Anders Kaseorg 4fe706a4d3 src/test/local.test: Set TERM=xterm
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-19 18:31:29 -05:00
Anders Kaseorg f0f83f5c4e src/tests/inpty.cc: Send the inner stderr to the outer stderr
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-19 18:31:29 -05:00
Anders Kaseorg 94027efc45 Make all commands properly support --help and --version
These should output to stdout and exit with status 0.  Passing
std-options to AM_INIT_AUTOMAKE causes ‘make installcheck’ (hence also
‘make distcheck’) to verify this.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-19 17:15:48 -05:00
John Hood e8f1004f94 append_move(): improve awkward control flow, naming 2016-11-19 17:14:37 -05:00
John Hood 302c7deb41 Describe Cell width as a narrow/wide boolean.
A character cell can only be either narrow or wide.  It's more
convenient to represent that as an int containing 1 or 2, but slightly
more correct to represent it as a "boolean" single-bit integer.
2016-11-17 00:56:31 -05:00
John Hood 71fe4441ef Shrink Cell to its prior size by using bitfields. 2016-11-17 00:56:05 -05:00
John Hood e4aed30d30 Fix broken wrap behavior causing broken copy/paste.
The terminal framebuffer was not resetting the wrap state of a row
when a previously-wrapping line was overwritten by a non-wrapping
line.  Restore previous, subtle behavior of line wrap.  Fix wrap
verification bug now exposed by emulation-wrap-across-frames.test.

Also hoist some getters, mostly for clarity.

Fixes #820.
2016-11-17 00:50:46 -05:00
Anders Kaseorg f7f741dab4 src/tests/inpty.cc: Skip the test on forkpty failures
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-13 16:13:25 -05:00
john hood 74469a7592 inpty.cc: Align configuration to be like mosh-server.cc.
This fixes a FreeBSD 11.0 build failure.
2016-11-12 23:25:56 -05:00
Anders Kaseorg 43251ea8db Add a trivial test that the mosh script works without needing tmux
None of the previous tests even ran the mosh script unless tmux ≥ 1.8 is
installed.  Thus ‘make check’ was “passing” on, e.g., RHEL 6 even though
its Perl is too old (5.10.1).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-12 23:25:35 -05:00
John Hood c9d0c9c0c5 tests/prediction-unicode.test: env -u is not POSIX
Seen to fail on OpenBSD 5.2.
2016-11-12 15:33:07 -05:00
John Hood 52d10cf211 Add a test for spinning on no-change screen updates 2016-11-06 06:15:42 -05:00
John Hood dc292dcdaa Test for spinning Mosh 2016-11-06 06:15:42 -05:00
John Hood 9c55198635 Fix off-by-one error on timeouts for input history echo updates 2016-11-06 06:15:42 -05:00
John Hood 3e414c46b3 Update send/ack timers on empty diff
The root problem here is that writes to the frame buffer may alter it,
but leave it with the same contents as before, and the diff between
the two states is the empty string.  With the dirty-rows,
smart-pointer changes to Framebuffer, it is easy to run into this
situation.  This got Network::TransportSender confused about timeouts,
and mosh-server would spin.

The theoretically correct fix would be to have operator==() exactly
correspond to diff(otherstate).empty().  I have partly implemented
this (and may yet finish) but it's not trivial to get right.

This is a much simpler fix that simply attempts to correctly update
timers when two framebuffers are different and an empty diff is
generated.
2016-11-06 06:15:41 -05:00
John Hood 9ffbeddbc8 Put spin debug under -vv flag, and add to mosh-client 2016-11-06 06:15:41 -05:00
John Hood f89f1da0b5 Log/limit pselect() with timeout of 0
This is not a fix for bad timeouts, but rather a band-aid
to keep Mosh from consuming large amounts of CPU time.
2016-11-06 06:15:41 -05:00
John Hood 444eae1fc4 Add tests to run Mosh repeatedly. 2016-11-06 06:15:41 -05:00
John Hood 22f5d58144 Exit gracefully on pty write or ioctl failure.
Fixes #821, OS X abnormal exit on client input at mosh-server
shutdown.  On OpenIndiana, TIOCG[GS]WINSZ also fail in this situation.
2016-11-06 06:14:02 -05:00
John Hood 4bc9e5c6ab Handle printing to closed pipes better in tests.
Some systems do not deliver SIGPIPE to shell pipeline writers when the
downstream reader has exited.  So, also check for errors from
/bin/printf.  I fixed this for OpenBSD 6.0 but I think it will also
fix posh on Linux.
2016-11-06 06:09:49 -05:00
John Hood 795549aafb OpenIndiana pid_t is long int 2016-11-06 06:09:49 -05:00
John Hood dd9ee1c4b7 Remove unused include 2016-11-06 02:47:20 -05:00
Anders Kaseorg b76d1bd526 e2e-test: Add newline to “unknown test type argument” error
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-04 03:15:03 -04:00
Anders Kaseorg 8a8f2b29ca Fix most shell hygiene issues found by shellcheck
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-04 03:15:03 -04:00
John Hood 9005ea6cf3 Use a table lookup for base64 decode 2016-10-29 20:50:33 -04:00
Jakub Wilk 42d686882f Fix typos 2016-10-09 16:04:42 +02:00
John Hood f429fd38b0 Use old AppleCommonCrypto name for AES 2016-09-25 22:24:03 -04:00
John Hood 477729b315 tests: improve robustness
Replace some blind timeouts with actual synchronization.
Improve performance on some slow tests.
Tweak some of the remaining timeouts.

This still isn't good enough to get 'make -j9 check'
working reliably on Cygwin for me; I think some Cygwin/
Windows scheduling issues remain.
2016-09-20 06:25:43 -04:00
John Hood e734d5e41a tests: Work around tmux display corruption bug on OpenBSD.
See https://github.com/tmux/tmux/issues/539
2016-09-19 13:23:16 -04:00
John Hood 1077db41b6 Support OpenBSD 6.0 pledge() syscall for sandboxing. 2016-09-19 13:23:16 -04:00
John Hood 5619dd47bb tests: fix incorrect usage of "trap ... SIGHUP"
Discovered with OpenBSD 6.0 /bin/sh
2016-09-19 13:23:16 -04:00
John Hood 39ea3d9512 Fix excess newlines on mosh startup/shutdown.
Fixes #788.

This also works around issues with remote pty typeahead echo corrupting output
from mosh-server.
2016-09-19 13:23:16 -04:00
John Hood 70d48fbcc0 Add --no-ssh-pty option.
This eliminates issues with typeahead being echoed by the remote pty
and corrupting remote output from mosh-server to the mosh script, but
cannot be made default because older mosh-servers require a pty.
2016-09-19 13:23:15 -04:00