Ashley Hedberg
4306b7cd42
Use pipe to communicate between client and server at startup
...
Fixes empty line on login
2023-08-07 20:59:47 -04:00
Alex Chernyakhovsky
cf542739cc
Switch to C++ versions of standard C headers
2023-07-30 19:02:51 -04:00
Alex Chernyakhovsky
19ad493dcb
Remove using-declarations for std:: types
2023-07-30 19:02:51 -04:00
Alex Chernyakhovsky
8469db91db
Modernize all typedefs with using statements
2023-07-30 19:02:51 -04:00
Alex Chernyakhovsky
38c84a9330
Removed shared_ptr shim
...
Since C++17 is now the default mosh version, remove the shared_ptr
shim in favor of std::shared_ptr.
2023-07-30 19:02:51 -04:00
Alex Chernyakhovsky
325098ac07
Switch to fully-qualified #include
...
Previously, mosh used extensive -I flags and all of the mosh-local
makes it really hard to tell what the proper dependency graph is, so
instead remove the -I arguments in favvor of $(top_srcdir) and qualify
the paths wherever they are used.
2023-07-30 17:03:40 -04:00
Benjamin Barenblat
cd7050613c
Audit and fix up format strings
2022-08-03 19:59:56 -04:00
John Hood
03087e7a76
If exec()ing the remote command fails, pause briefly
...
This makes the resulting error from mosh-server visible in ordinary usage.
2020-05-18 00:01:05 -04:00
Peter Edwards
c3a2756065
Apply latest consecutive resize, not earliest.
...
If there are consecutive resize events in the userstream to be applied in
"serve", we should apply the last/latest one in the sequence, not the
first/earliest one.
This fixes a problem where a flurry of resize events (eg, generated
by a window manager resizing the client), can cause mosh to have an
out-of-date idea as to what the physical geometry of the window is.
2019-01-04 04:06:30 -08:00
John Hood
756f4f8e98
Remove "using namespace std;".
2018-08-15 19:27:23 -04:00
John Hood
fb23168ed9
Always use std::min, std::max.
2018-08-15 19:26:27 -04:00
John Hood
3ea9e3e5a4
mosh-server: improve error logging
...
Also stop using _exit(), believed unnecessary now with proper stdio
flushing.
2018-08-03 15:16:55 -04:00
John Hood
2a5b5410b2
Fix gcc8 snprintf truncation warning.
2018-04-11 18:10:59 -04:00
Michael Jarvis
21d5dca682
Use HAVE_UTEMPTER instead of HAVE_UPTEMPTER
...
Fix typo for issue #942 :
- mosh-server incorrectly reports detached session in utmp/wtmp
2017-11-21 06:05:33 -06:00
Tom Judge
ab31b0f271
Add syslog logging of connections
...
Log connection change events to syslog in the auth log, logging the PID,
username and remote host.
Also log session begin and end.
Co-Authored-By: John Hood <cgull@glup.org >
2017-11-05 11:54:43 -05:00
John Hood
4835dcf5ee
Various switch statement fixes.
2017-08-06 22:22:25 -04:00
John Hood
3346419724
Remove excessive parentheses
...
There are many more.
2017-08-06 22:22:20 -04:00
John Hood
43785eb820
Collapse nested conditionals.
2017-08-06 22:21:56 -04:00
John Hood
42d2b5d029
Use shared_ptr and references for Actions.
...
This slows terminal emulation slightly.
2017-08-02 22:07:02 -04:00
John Hood
8f68400c13
Convert new/delete to shared_ptr.
2017-08-02 22:07:02 -04:00
John Hood
4902970486
Fix utempter #ifdefs.
2017-08-02 22:07:02 -04:00
John Hood
48e9dd169f
Reformat printed strings in source
...
Consolidate multiple printfs.
Break up multiline strings with string concatentation, for better
clarity and shorter lines.
Use fputs where appropriate.
This also has the benefit of producing a single constant string with
copyright and versions in the binaries.
2017-08-02 00:02:52 -04:00
John Hood
32b1e6ee4b
Print {,/var}/run/motd.dynamic on Ubuntu.
2017-04-24 22:40:30 -04:00
John Hood
3f0ac51071
Don't print /etc/motd on IllumOS.
2017-04-24 22:40:30 -04:00
Jérémie Courrèges-Anglas
c0bf8053b2
Remove deprecated pledge("ioctl")
...
Unbreaks mosh on recent (> 2017/03/18) OpenBSD systems.
2017-03-20 09:54:33 -04:00
John Hood
bb54325dc9
s/geteuid/getuid/ for correct user lookups
...
Addresses an issue mentioned in #193 .
2016-11-23 17:03:45 -05:00
Anders Kaseorg
94027efc45
Make all commands properly support --help and --version
...
These should output to stdout and exit with status 0. Passing
std-options to AM_INIT_AUTOMAKE causes ‘make installcheck’ (hence also
‘make distcheck’) to verify this.
Signed-off-by: Anders Kaseorg <andersk@mit.edu >
2016-11-19 17:15:48 -05:00
John Hood
9ffbeddbc8
Put spin debug under -vv flag, and add to mosh-client
2016-11-06 06:15:41 -05:00
John Hood
22f5d58144
Exit gracefully on pty write or ioctl failure.
...
Fixes #821 , OS X abnormal exit on client input at mosh-server
shutdown. On OpenIndiana, TIOCG[GS]WINSZ also fail in this situation.
2016-11-06 06:14:02 -05:00
John Hood
795549aafb
OpenIndiana pid_t is long int
2016-11-06 06:09:49 -05:00
John Hood
1077db41b6
Support OpenBSD 6.0 pledge() syscall for sandboxing.
2016-09-19 13:23:16 -04:00
John Hood
39ea3d9512
Fix excess newlines on mosh startup/shutdown.
...
Fixes #788 .
This also works around issues with remote pty typeahead echo corrupting output
from mosh-server.
2016-09-19 13:23:16 -04:00
John Hood
70d48fbcc0
Add --no-ssh-pty option.
...
This eliminates issues with typeahead being echoed by the remote pty
and corrupting remote output from mosh-server to the mosh script, but
cannot be made default because older mosh-servers require a pty.
2016-09-19 13:23:15 -04:00
John Hood
4ad131a55d
Fix lost MOSH CONNECT on FreeBSD 11
...
This moves all routine stdout/stderr output into the parent
server, and adds tcdrain(), even though this may be a
FreeBSD pty bug.
2016-09-18 01:53:36 -04:00
John Hood
882539884e
Remove unnecessary usage of #include <iostream>. Rename templated impls from .cc to -impl.h.
2016-05-14 00:10:59 -04:00
John Hood
da30bb74a2
Coverity fixes: deref of stale pointer
...
I think this one was actually impossible to trigger.
2016-05-10 23:57:29 -04:00
John Hood
880c639361
Include POSIX header strings.h for strncasecmp()
...
Motivated by Cygwin.
2016-05-08 20:46:58 -04:00
John Hood
d4832ca63a
Fix bugs in resize handling.
...
* A resize action could be applied to the framebuffer but discarded
before being applied to termios, causing them to be out of sync.
* Only every second action was skipped, instead of skipping
consecutive resize actions, as intended.
Found by inspection, not seen in actual usage or by the window-resize
test.
2016-03-30 23:52:19 -04:00
John Hood
1de6575e59
mosh-server.cc: Do not start user shell until network session starts
2016-03-30 23:52:19 -04:00
John Hood
ca21788c96
Remove usage of exceptional fdsets with select().
2016-01-11 04:35:21 -05:00
John Hood
90a529b18a
Fix broken compile on Ubuntu 12.04
2015-12-07 00:25:47 -05:00
john hood
8609f88207
mosh-server: Fix hang with ^S on OS X and FreeBSD.
...
Fixes #692 .
2015-12-06 19:09:42 -05:00
John Hood
1e003b0e76
mosh-server: skip redundant resize requests
...
This might reduce redraw activity on window resize, especially for
slow servers.
2015-12-06 17:47:11 -05:00
John Hood
992fec1f30
e2e-test: Add check for Instruction verification failures.
2015-12-06 17:47:11 -05:00
John Hood
b742e958b6
mosh-server: Support timeouts on lost connectivity to network client.
...
Closes #690 .
2015-11-24 02:36:08 -05:00
Andrew Chin
8b5b7aedfa
Make --help or -h work again
...
Also make --help go to stdout, but everywhere else print_help is used,
go to stderr
Signed-off-by: Andrew Chin <achin@eminence32.net >
2015-11-01 01:09:00 -04:00
John Hood
7fb542c874
Change SSH_CONNECTION fallback to allow IPv6
2015-10-03 03:43:18 -04:00
Keith Winstein
2e4e601468
mosh-server.cc: compare like types.
...
Fixes #626 (resize not working) introduced by 543f346a
2015-06-09 15:17:48 -07:00
John Hood
543f346ac7
Fix various new compiler warnings.
...
terminalfunctions.cc: set_if_available() was undeclared.
Fix printf() wint_t/wchar_t warnings.
mosh-server.cc: Fix warning for side effects inside typeid().
Signed-off-by: John Hood <cgull@glup.org >
2015-06-06 13:12:32 -04:00
Anders Kaseorg
b604a7d7c2
Respect HOME environment variable if set
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu >
2015-06-05 22:53:31 -04:00