1465 Commits

Author SHA1 Message Date
John Hood 9663edb7c7 Do not set function parameters. 2017-08-06 22:22:32 -04:00
John Hood 2b3034b320 Remove private static class methods. 2017-08-06 22:22:29 -04:00
John Hood 4835dcf5ee Various switch statement fixes. 2017-08-06 22:22:25 -04:00
John Hood 3346419724 Remove excessive parentheses
There are many more.
2017-08-06 22:22:20 -04:00
John Hood 1ae23b4dcc Prefer early exit/break to large conditional blocks.
Some of these are large and contain smaller unrelated refactors.
2017-08-06 22:22:09 -04:00
John Hood b1a6f7c144 Eliminate unnecessary, trailing else conditional blocks. 2017-08-06 22:22:05 -04:00
John Hood 43785eb820 Collapse nested conditionals. 2017-08-06 22:21:56 -04:00
John Hood 8ca8a54e11 Split a long printf format string. 2017-08-06 22:21:38 -04:00
John Hood 9df71ae5ad Add support for OCLint static checker. 2017-08-06 22:00:24 -04:00
John Hood 4f068d7261 Improve targets for existing static checkers. 2017-08-06 21:59:57 -04:00
Anders Kaseorg 271e8ba318 Remove unused Action::operator==
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-08-02 22:59:42 -04:00
John Hood 2b724d5868 Simplify some conditionals in terminaloverlay.cc. 2017-08-02 22:56:19 -04:00
John Hood 42d2b5d029 Use shared_ptr and references for Actions.
This slows terminal emulation slightly.
2017-08-02 22:07:02 -04:00
John Hood c6c7f09954 Deref a shared pointer in a per-byte loop 2017-08-02 22:07:02 -04:00
John Hood 8f68400c13 Convert new/delete to shared_ptr. 2017-08-02 22:07:02 -04:00
John Hood eef77fd5a5 Convert strdup/free to string 2017-08-02 22:07:02 -04:00
John Hood 6321b1d9c5 Remove redundant malloc/free 2017-08-02 22:07:02 -04:00
John Hood 54ac38bfd8 remove unneeded new/delete in Compressor 2017-08-02 22:07:02 -04:00
John Hood 33afb3abc1 Remove redundant new/delete 2017-08-02 22:07:02 -04:00
John Hood a3b05e69b6 Add missing shared::make_shared<T>() 2017-08-02 22:07:02 -04:00
John Hood 4902970486 Fix utempter #ifdefs. 2017-08-02 22:07:02 -04:00
John Hood c8580d1fb6 Rename and document --predict-overwrite. 2017-08-02 21:56:32 -04:00
John Hood c49c67cecf --predict-overwrite was still inserting one column sometimes. Fix. 2017-08-02 21:56:32 -04:00
John Hood 8aac3cc927 Allow non-inserting prediction.
This may be useful for users who find prediction's activity right of
the cursor distracting.

Prediction underscoring is still a little weird sometimes, it replays
a history of known/unknown changes as acks come in from the server.
2017-08-02 00:31:37 -04:00
John Hood 91de8901f5 Don't do prediction on large pastes into mosh-client.
Fixes #482, memory use blowup on large pastes.  mosh is still pretty slow
about copying pastes through, though.
2017-08-02 00:31:37 -04:00
John Hood 48e9dd169f Reformat printed strings in source
Consolidate multiple printfs.
Break up multiline strings with string concatentation, for better
 clarity and shorter lines.
Use fputs where appropriate.

This also has the benefit of producing a single constant string with
copyright and versions in the binaries.
2017-08-02 00:02:52 -04:00
Alex Cornejo 4b240ac033 support osc 52 clipboard copy integration.
This feature is particularly relevant for mosh for chrome (which also
used in windows I believe).
2017-07-31 23:17:24 -04:00
Keith Winstein 04f6dafb58 debian/control: update standards version 2017-07-23 11:09:10 -07:00
Keith Winstein cf73e1f879 Update version to 1.3.2 (fixes Debian revision inversion) 2017-07-21 14:53:57 -07:00
John Hood dedb2c5b6f mosh 1.3.1 2017-07-20 17:45:41 -04:00
John Hood e054a86ecc mosh 1.3.1-rc3 2017-07-19 22:31:28 -04:00
John Hood 7c68667bc0 Explicitly set tmux window size in tests.
Recent versions of tmux master gave us an 80x23 window.  tmux has been
fixed to default to 80x24, and also to allow setting window sizes in
control mode.  These flags fortunately do not conflict with older
versions tmux.  So we use them to avoid problems going forward.
2017-05-28 21:19:03 -04:00
John Hood 73fc71376a Add a pause mechanism for debugging tests. 2017-05-28 19:28:04 -04:00
John Hood d15d342df3 Tests: symlink to tmux sockets
This makes it easier to attach a second client to inspect a test.
2017-05-28 19:27:39 -04:00
John Hood 2f89ac0ac7 Make tmux version check work with tmux master. 2017-05-28 13:19:12 -04:00
Giel van Schijndel cb91788d05 When binding on the IPv6 any address bind for IPv4 too
On some Linux systems this is the default. On most other operating
systems accepting IPv4 connections on a IPv6 socket only happens when
explicitly requested. Even on Linux it depends on the sysctl config.

This change makes it independent from the system's defaults whether IPv4
connections will be accepted too through the same socket.
2017-05-22 22:33:45 -04:00
John Hood 9f54cc76d2 Detect broken tmux in tests
This works around Debian kfreebsd build failures.
2017-05-21 12:49:18 -04:00
John Hood b17c5795f7 Update to 1.3.1-rc2. 2017-05-19 19:29:34 -04:00
John Hood a6d580a7c5 Set locale more correctly in tests
This fixes Debian builds which only have LC_ALL=POSIX set.
2017-05-18 23:22:55 -04:00
Keith Winstein 9cd9105cec Update changelog release dates to May 18 for 1.3.1-rc1 2017-05-18 00:52:49 -04:00
John Hood 561ac25d76 Version 1.3.1 rc1. Update changelogs. 2017-05-08 23:39:48 -04:00
John Hood 2fe33ff009 Disable unicode-later-combining.test for tmux 2.4. 2017-05-07 20:51:31 -04:00
John Hood 23ec4e59cb Revert "Disable unicode-later-combining.test for now"
This reverts commit df4dbe0d6c.
2017-05-07 20:28:14 -04:00
John Hood d205a98a87 Test for SCROLL UP and SCROLL DOWN. 2017-05-06 11:23:56 -04:00
John Hood 72199ffc0b Do not move cursor for SCROLL UP and SCROLL DOWN
This fixes #881, corrupted display of man pages with tables in tmux
2.4.
2017-05-06 11:15:43 -04:00
John Hood df4dbe0d6c Disable unicode-later-combining.test for now
tmux 2.4+ has serious bugs with combining characters.
2017-04-26 01:25:59 -04:00
John Hood 2873def506 Work around JuiceSSH rendering bug
JuiceSSH apparently has a bug where ECH for one character (ESC [ 1 X) does
not actually erase the character, in its code that receives and interprets
Mosh state updates.  This was hidden before because Mosh <= 1.2.5 never sent
this sequence, it sent ESC [ X instead as an optimization.

Do the better optimization of sending spaces for short sequences of blanks
instead.
2017-04-24 22:40:31 -04:00
Adrien Destugues aa74af9a34 Fix build on Haiku.
- Look for socket in libnetwork
- Look for forkpty in libbsd
2017-04-24 22:40:31 -04:00
John Hood 32b1e6ee4b Print {,/var}/run/motd.dynamic on Ubuntu. 2017-04-24 22:40:30 -04:00
John Hood 3f0ac51071 Don't print /etc/motd on IllumOS. 2017-04-24 22:40:30 -04:00