izackp/mosh
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

human_readable_duration, Terminal::appendstring: Pass strings by reference

Browse Source 
Found by cppcheck.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
Anders Kaseorg
2013-02-18 02:07:11 -05:00
committed by Keith Winstein
parent e2abb8524f
commit d0eeabb51e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/frontend/terminaloverlay.cc
+1 -1
View File
@@ -172,7 +172,7 @@ NotificationEngine::NotificationEngine()
show_quit_keystroke( true ) show_quit_keystroke( true )
{} {}
static std::string human_readable_duration( int num_seconds, const std::string seconds_abbr ) { static std::string human_readable_duration( int num_seconds, const std::string &seconds_abbr ) {
char tmp[ 128 ]; char tmp[ 128 ];
if ( num_seconds < 60 ) { if ( num_seconds < 60 ) {
snprintf( tmp, 128, "%d %s", num_seconds, seconds_abbr.c_str() ); snprintf( tmp, 128, "%d %s", num_seconds, seconds_abbr.c_str() );
src/terminal/terminaldisplay.h
+1 -1
View File
@@ -58,7 +58,7 @@ namespace Terminal {
} }
void append( const char * s ) { str.append( s ); } void append( const char * s ) { str.append( s ); }
void appendstring( const std::string s ) { str.append( s ); } void appendstring( const std::string &s ) { str.append( s ); }
void append_silent_move( int y, int x ); void append_silent_move( int y, int x );
}; };