Fix most shell hygiene issues found by shellcheck

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
Anders Kaseorg
2016-10-30 02:05:31 -04:00
committed by John Hood
parent 3b21cd2425
commit 8a8f2b29ca
20 changed files with 144 additions and 115 deletions
+10 -9
View File
@@ -4,11 +4,12 @@
# This test is for issue 539 on github.
#
. $(dirname $0)/e2e-test-subrs
# shellcheck source=e2e-test-subrs
. "$(dirname "$0")/e2e-test-subrs"
PATH=$PATH:.:$srcdir
# Top-level wrapper.
if [ $# -eq 0 ]; then
e2e-test $0 baseline post
e2e-test "$0" baseline post
exit
fi
@@ -29,17 +30,17 @@ baseline()
post()
{
# Basic previously-failing case.
if grep -q 'hello, wurldo' $(basename $0).d/baseline.capture; then
if grep -q 'hello, wurldo' "$(basename "$0").d/baseline.capture"; then
exit 1
fi
if ! grep -q 'hello, world' $(basename $0).d/baseline.capture; then
if ! grep -q 'hello, world' "$(basename "$0").d/baseline.capture"; then
exit 99
fi
# New test cases for new code.
if ! grep -q 'oello, wurld' $(basename $0).d/baseline.capture ||
! grep -q '9ello, wurld' $(basename $0).d/baseline.capture ||
! grep -q 'hello, wurld t' $(basename $0).d/baseline.capture ||
! grep -E -q '^ {79}#$' $(basename $0).d/baseline.capture; then
if ! grep -q 'oello, wurld' "$(basename "$0").d/baseline.capture" ||
! grep -q '9ello, wurld' "$(basename "$0").d/baseline.capture" ||
! grep -q 'hello, wurld t' "$(basename "$0").d/baseline.capture" ||
! grep -E -q '^ {79}#$' "$(basename "$0").d/baseline.capture"; then
exit 1
fi
exit 0
@@ -51,5 +52,5 @@ case $1 in
post)
post;;
*)
fail "unknown test argument %s\n" $1;;
fail "unknown test argument %s\n" "$1";;
esac