Revert use of protobuf's Gzip streams.

Unfortunately some Red Hat-based distributions lack the required header.
See https://bugzilla.redhat.com/show_bug.cgi?id=815587

This reverts commit 261a389a76.
This reverts commit b6736eb0a5.
This commit is contained in:
Keith Winstein
2012-04-23 22:49:32 -04:00
parent 905176c2b9
commit 63459ed1c7
5 changed files with 69 additions and 29 deletions
+1 -1
View File
@@ -3,4 +3,4 @@ AM_CXXFLAGS = $(WARNING_CXXFLAGS) $(PICKY_CXXFLAGS) $(HARDEN_CFLAGS) $(MISC_CXXF
noinst_LIBRARIES = libmoshnetwork.a
libmoshnetwork_a_SOURCES = network.cc network.h networktransport.cc networktransport.h transportfragment.cc transportfragment.h transportsender.cc transportsender.h transportstate.h
libmoshnetwork_a_SOURCES = network.cc network.h networktransport.cc networktransport.h transportfragment.cc transportfragment.h transportsender.cc transportsender.h transportstate.h compressor.cc compressor.h
+32
View File
@@ -0,0 +1,32 @@
#include <zlib.h>
#include "compressor.h"
#include "dos_assert.h"
using namespace Network;
using namespace std;
string Compressor::compress_str( const string &input )
{
long unsigned int len = BUFFER_SIZE;
dos_assert( Z_OK == compress( buffer, &len,
reinterpret_cast<const unsigned char *>( input.data() ),
input.size() ) );
return string( reinterpret_cast<char *>( buffer ), len );
}
string Compressor::uncompress_str( const string &input )
{
long unsigned int len = BUFFER_SIZE;
dos_assert( Z_OK == uncompress( buffer, &len,
reinterpret_cast<const unsigned char *>( input.data() ),
input.size() ) );
return string( reinterpret_cast<char *>( buffer ), len );
}
/* construct on first use */
Compressor & Network::get_compressor( void )
{
static Compressor the_compressor;
return the_compressor;
}
+28
View File
@@ -0,0 +1,28 @@
#ifndef COMPRESSOR_H
#define COMPRESSOR_H
#include <string>
namespace Network {
class Compressor {
private:
static const int BUFFER_SIZE = 2048 * 2048; /* effective limit on terminal size */
unsigned char *buffer;
public:
Compressor() : buffer( NULL ) { buffer = new unsigned char[ BUFFER_SIZE ]; }
~Compressor() { if ( buffer ) { delete[] buffer; } }
std::string compress_str( const std::string &input );
std::string uncompress_str( const std::string &input );
/* unused */
Compressor( const Compressor & );
Compressor & operator=( const Compressor & );
};
Compressor & get_compressor( void );
}
#endif
+6 -28
View File
@@ -17,15 +17,13 @@
*/
#include <assert.h>
#include <google/protobuf/io/gzip_stream.h>
#include <google/protobuf/io/zero_copy_stream_impl.h>
#include "byteorder.h"
#include "transportfragment.h"
#include "transportinstruction.pb.h"
#include "compressor.h"
#include "fatal_assert.h"
using namespace google::protobuf::io;
using namespace Network;
using namespace TransportBuffers;
@@ -117,24 +115,15 @@ Instruction FragmentAssembly::get_assembly( void )
{
assert( fragments_arrived == fragments_total );
ZeroCopyInputStream **streams = new ZeroCopyInputStream *[fragments_total];
string encoded;
for ( int i = 0; i < fragments_total; i++ ) {
assert( fragments.at( i ).initialized );
streams[i] = new ArrayInputStream( fragments.at( i ).contents.data(),
fragments.at( i ).contents.size() );
encoded += fragments.at( i ).contents;
}
Instruction ret;
{
ConcatenatingInputStream stream( streams, fragments_total );
GzipInputStream gzip_stream( &stream, GzipInputStream::ZLIB );
fatal_assert( ret.ParseFromZeroCopyStream( &gzip_stream ) );
}
for ( int i = 0; i < fragments_total; i++ ) {
delete streams[i];
}
delete[] streams;
fatal_assert( ret.ParseFromString( get_compressor().uncompress_str( encoded ) ) );
fragments.clear();
fragments_arrived = 0;
@@ -169,18 +158,7 @@ vector<Fragment> Fragmenter::make_fragments( const Instruction &inst, int MTU )
last_instruction = inst;
last_MTU = MTU;
string payload;
{
StringOutputStream stream( &payload );
GzipOutputStream::Options gzip_options;
gzip_options.format = GzipOutputStream::ZLIB;
GzipOutputStream gzip_stream( &stream, gzip_options );
fatal_assert( inst.SerializeToZeroCopyStream( &gzip_stream ) );
if ( !gzip_stream.Close() ) {
throw std::string( "zlib error: " ) + gzip_stream.ZlibErrorMessage();
}
}
string payload = get_compressor().compress_str( inst.SerializeAsString() );
uint16_t fragment_num = 0;
vector<Fragment> ret;