izackp/Apollo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix and enable -Wmaybe-uninitialized

Browse Source
This commit is contained in:
Cameron Gutman
2023-05-10 23:57:08 -05:00
parent f08ba0fd7c
commit 8db0ad0cc6
5 changed files with 16 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@@ -140,7 +140,7 @@ endif()
find_package(Boost COMPONENTS locale log filesystem program_options REQUIRED) find_package(Boost COMPONENTS locale log filesystem program_options REQUIRED)
list(APPEND SUNSHINE_COMPILE_OPTIONS -Wall -Wno-missing-braces -Wno-maybe-uninitialized -Wno-sign-compare) list(APPEND SUNSHINE_COMPILE_OPTIONS -Wall -Wno-missing-braces -Wno-sign-compare)
# enable system tray, we will disable this later if we cannot find the required package config on linux # enable system tray, we will disable this later if we cannot find the required package config on linux
set(SUNSHINE_TRAY 1) set(SUNSHINE_TRAY 1)

12
src/platform/linux/misc.cpp
View File

@@ -103,15 +103,14 @@ namespace platf {
std::string std::string
from_sockaddr(const sockaddr *const ip_addr) { from_sockaddr(const sockaddr *const ip_addr) {
char data[INET6_ADDRSTRLEN]; char data[INET6_ADDRSTRLEN] = {};
auto family = ip_addr->sa_family; auto family = ip_addr->sa_family;
if (family == AF_INET6) { if (family == AF_INET6) {
inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data, inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data,
INET6_ADDRSTRLEN); INET6_ADDRSTRLEN);
} }
else if (family == AF_INET) {
if (family == AF_INET) {
inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data, inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data,
INET_ADDRSTRLEN); INET_ADDRSTRLEN);
} }
@@ -121,17 +120,16 @@ namespace platf {
std::pair<std::uint16_t, std::string> std::pair<std::uint16_t, std::string>
from_sockaddr_ex(const sockaddr *const ip_addr) { from_sockaddr_ex(const sockaddr *const ip_addr) {
char data[INET6_ADDRSTRLEN]; char data[INET6_ADDRSTRLEN] = {};
auto family = ip_addr->sa_family; auto family = ip_addr->sa_family;
std::uint16_t port; std::uint16_t port = 0;
if (family == AF_INET6) { if (family == AF_INET6) {
inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data, inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data,
INET6_ADDRSTRLEN); INET6_ADDRSTRLEN);
port = ((sockaddr_in6 *) ip_addr)->sin6_port; port = ((sockaddr_in6 *) ip_addr)->sin6_port;
} }
else if (family == AF_INET) {
if (family == AF_INET) {
inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data, inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data,
INET_ADDRSTRLEN); INET_ADDRSTRLEN);
port = ((sockaddr_in *) ip_addr)->sin_port; port = ((sockaddr_in *) ip_addr)->sin_port;

12
src/platform/macos/misc.mm
View File

@@ -86,15 +86,14 @@ namespace platf {
std::string std::string
from_sockaddr(const sockaddr *const ip_addr) { from_sockaddr(const sockaddr *const ip_addr) {
char data[INET6_ADDRSTRLEN]; char data[INET6_ADDRSTRLEN] = {};
auto family = ip_addr->sa_family; auto family = ip_addr->sa_family;
if (family == AF_INET6) { if (family == AF_INET6) {
inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data, inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data,
INET6_ADDRSTRLEN); INET6_ADDRSTRLEN);
} }
else if (family == AF_INET) {
if (family == AF_INET) {
inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data, inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data,
INET_ADDRSTRLEN); INET_ADDRSTRLEN);
} }
@@ -104,17 +103,16 @@ namespace platf {
std::pair<std::uint16_t, std::string> std::pair<std::uint16_t, std::string>
from_sockaddr_ex(const sockaddr *const ip_addr) { from_sockaddr_ex(const sockaddr *const ip_addr) {
char data[INET6_ADDRSTRLEN]; char data[INET6_ADDRSTRLEN] = {};
auto family = ip_addr->sa_family; auto family = ip_addr->sa_family;
std::uint16_t port; std::uint16_t port = 0;
if (family == AF_INET6) { if (family == AF_INET6) {
inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data, inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data,
INET6_ADDRSTRLEN); INET6_ADDRSTRLEN);
port = ((sockaddr_in6 *) ip_addr)->sin6_port; port = ((sockaddr_in6 *) ip_addr)->sin6_port;
} }
else if (family == AF_INET) {
if (family == AF_INET) {
inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data, inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data,
INET_ADDRSTRLEN); INET_ADDRSTRLEN);
port = ((sockaddr_in *) ip_addr)->sin_port; port = ((sockaddr_in *) ip_addr)->sin_port;

12
src/platform/windows/misc.cpp
View File

@@ -81,14 +81,13 @@ namespace platf {
std::string std::string
from_sockaddr(const sockaddr *const socket_address) { from_sockaddr(const sockaddr *const socket_address) {
char data[INET6_ADDRSTRLEN]; char data[INET6_ADDRSTRLEN] = {};
auto family = socket_address->sa_family; auto family = socket_address->sa_family;
if (family == AF_INET6) { if (family == AF_INET6) {
inet_ntop(AF_INET6, &((sockaddr_in6 *) socket_address)->sin6_addr, data, INET6_ADDRSTRLEN); inet_ntop(AF_INET6, &((sockaddr_in6 *) socket_address)->sin6_addr, data, INET6_ADDRSTRLEN);
} }
else if (family == AF_INET) {
if (family == AF_INET) {
inet_ntop(AF_INET, &((sockaddr_in *) socket_address)->sin_addr, data, INET_ADDRSTRLEN); inet_ntop(AF_INET, &((sockaddr_in *) socket_address)->sin_addr, data, INET_ADDRSTRLEN);
} }
@@ -97,16 +96,15 @@ namespace platf {
std::pair<std::uint16_t, std::string> std::pair<std::uint16_t, std::string>
from_sockaddr_ex(const sockaddr *const ip_addr) { from_sockaddr_ex(const sockaddr *const ip_addr) {
char data[INET6_ADDRSTRLEN]; char data[INET6_ADDRSTRLEN] = {};
auto family = ip_addr->sa_family; auto family = ip_addr->sa_family;
std::uint16_t port; std::uint16_t port = 0;
if (family == AF_INET6) { if (family == AF_INET6) {
inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data, INET6_ADDRSTRLEN); inet_ntop(AF_INET6, &((sockaddr_in6 *) ip_addr)->sin6_addr, data, INET6_ADDRSTRLEN);
port = ((sockaddr_in6 *) ip_addr)->sin6_port; port = ((sockaddr_in6 *) ip_addr)->sin6_port;
} }
else if (family == AF_INET) {
if (family == AF_INET) {
inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data, INET_ADDRSTRLEN); inet_ntop(AF_INET, &((sockaddr_in *) ip_addr)->sin_addr, data, INET_ADDRSTRLEN);
port = ((sockaddr_in *) ip_addr)->sin_port; port = ((sockaddr_in *) ip_addr)->sin_port;
} }

1
src/video.cpp
View File

@@ -396,7 +396,6 @@ namespace video {
struct sync_session_t { struct sync_session_t {
sync_session_ctx_t *ctx; sync_session_ctx_t *ctx;
platf::img_t *img_tmp;
session_t session; session_t session;
}; };