izackp/Apollo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix discovery of Windows hosts by Apple devices

Browse Source
This commit is contained in:
Cameron Gutman
2023-12-03 21:45:10 -06:00
parent 6dcc5e7c0f
commit 4a2f7023ec
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/platform/windows/publish.cpp
View File

@@ -119,6 +119,21 @@ namespace platf::publish {
instance.wPort = map_port(nvhttp::PORT_HTTP); instance.wPort = map_port(nvhttp::PORT_HTTP);
instance.pszHostName = host.data(); instance.pszHostName = host.data();
// Setting these values ensures Windows mDNS answers comply with RFC 1035.
// If these are unset, Windows will send a TXT record that has zero strings,
// which is illegal. Setting them to a single empty value causes Windows to
// send a single empty string for the TXT record, which is the correct thing
// to do when advertising a service without any TXT strings.
//
// Most clients aren't strictly checking TXT record compliance with RFC 1035,
// but Apple's mDNS resolver does and rejects the entire answer if an invalid
// TXT record is present.
PWCHAR keys[] = { nullptr };
PWCHAR values[] = { nullptr };
instance.dwPropertyCount = 1;
instance.keys = keys;
instance.values = values;
DNS_SERVICE_REGISTER_REQUEST req {}; DNS_SERVICE_REGISTER_REQUEST req {};
req.Version = DNS_QUERY_REQUEST_VERSION1; req.Version = DNS_QUERY_REQUEST_VERSION1;
req.pQueryContext = alarm.get(); req.pQueryContext = alarm.get();