From 9bc09e9d3900e6e042fc1d16552d874c27aeef38 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 7 Aug 2024 23:07:51 +0000 Subject: [PATCH 1/3] build(deps): bump third-party/doxyconfig from `671b494` to `6d145da` (#2979) Bumps [third-party/doxyconfig](https://github.com/LizardByte/doxyconfig) from `671b494` to `6d145da`. - [Commits](https://github.com/LizardByte/doxyconfig/compare/671b494f3cbe8597a36d81869a864dc9fff497f4...6d145dab2ec1f387920036c7fffc1d08d52fe926) --- updated-dependencies: - dependency-name: third-party/doxyconfig dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com> --- .gitignore | 2 +- .readthedocs.yaml | 26 ++++++++------------------ third-party/doxyconfig | 2 +- 3 files changed, 10 insertions(+), 20 deletions(-) diff --git a/.gitignore b/.gitignore index 7b91ee4a..b3c5bd85 100644 --- a/.gitignore +++ b/.gitignore @@ -40,7 +40,7 @@ # build directories build/ cmake-*/ -docs/*-doxyconfig* +docs/doxyconfig* # npm node_modules/ diff --git a/.readthedocs.yaml b/.readthedocs.yaml index a2c132dc..ee2f3bb2 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -10,25 +10,15 @@ build: tools: python: "miniconda-latest" commands: - # because we are overriding the build commands, we need to setup the environment ourselves - - cat third-party/doxyconfig/environment.yml - - conda env create --quiet --name ${READTHEDOCS_VERSION} --file third-party/doxyconfig/environment.yml - - npm install "@fortawesome/fontawesome-free" - - mkdir -p ${READTHEDOCS_OUTPUT}html/assets/fontawesome/css - - mkdir -p ${READTHEDOCS_OUTPUT}html/assets/fontawesome/js - - cp node_modules/@fortawesome/fontawesome-free/css/all.min.css ${READTHEDOCS_OUTPUT}html/assets/fontawesome/css - - cp node_modules/@fortawesome/fontawesome-free/js/all.min.js ${READTHEDOCS_OUTPUT}html/assets/fontawesome/js - - cp -r node_modules/@fortawesome/fontawesome-free/webfonts ${READTHEDOCS_OUTPUT}html/assets/fontawesome/ - | - wget "https://raw.githubusercontent.com/LizardByte/.github/master/branding/logos/favicon.ico" \ - -O ${READTHEDOCS_OUTPUT}lizardbyte.ico - - | - wget "https://raw.githubusercontent.com/LizardByte/.github/master/branding/logos/logo-128x128.png" \ - -O ${READTHEDOCS_OUTPUT}lizardbyte.png - - cp ./third-party/doxyconfig/Doxyfile ./docs/Doxyfile-doxyconfig - - cp ./third-party/doxyconfig/header.html ./docs/header-doxyconfig.html - - cat ./docs/Doxyfile >> ./docs/Doxyfile-doxyconfig - - cd docs && doxygen Doxyfile-doxyconfig + if [ -f readthedocs_build.sh ]; then + doxyconfig_dir="." + else + doxyconfig_dir="./third-party/doxyconfig" + fi + chmod +x "${doxyconfig_dir}/readthedocs_build.sh" + export DOXYCONFIG_DIR="${doxyconfig_dir}" + "${doxyconfig_dir}/readthedocs_build.sh" # using conda, we can get newer doxygen and graphviz than ubuntu provide # https://github.com/readthedocs/readthedocs.org/issues/8151#issuecomment-890359661 diff --git a/third-party/doxyconfig b/third-party/doxyconfig index 671b494f..6d145dab 160000 --- a/third-party/doxyconfig +++ b/third-party/doxyconfig @@ -1 +1 @@ -Subproject commit 671b494f3cbe8597a36d81869a864dc9fff497f4 +Subproject commit 6d145dab2ec1f387920036c7fffc1d08d52fe926 From 64083c1679b75174f9fb1d5924a53ea262d4f348 Mon Sep 17 00:00:00 2001 From: Vithorio Polten Date: Wed, 7 Aug 2024 22:01:28 -0300 Subject: [PATCH 2/3] chore(issue-template): add Apple Silicon to GPUs (#2968) Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/bug-report.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index f0337455..422a0a64 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -122,6 +122,7 @@ body: description: The type of the installed graphics card. options: - AMD + - Apple Silicon - Intel - Nvidia - none (software encoding) From 04df80ff6b1d4b778edebd92851b1b8ca9f64f69 Mon Sep 17 00:00:00 2001 From: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com> Date: Wed, 7 Aug 2024 22:10:19 -0400 Subject: [PATCH 3/3] feat!: drop advertised resolutions and fps (#2924) --- src/config.cpp | 17 ------- src/config.h | 2 - src/nvhttp.cpp | 25 ---------- src_assets/common/assets/web/config.html | 40 ++-------------- .../assets/web/configs/tabs/AudioVideo.vue | 4 -- .../tabs/audiovideo/DisplayModesSettings.vue | 48 ------------------- .../assets/web/public/assets/locale/en.json | 3 -- 7 files changed, 3 insertions(+), 136 deletions(-) diff --git a/src/config.cpp b/src/config.cpp index 7f588863..e8accb15 100644 --- a/src/config.cpp +++ b/src/config.cpp @@ -407,21 +407,6 @@ namespace config { boost::asio::ip::host_name(), // sunshine_name, "sunshine_state.json"s, // file_state {}, // external_ip - { - "352x240"s, - "480x360"s, - "858x480"s, - "1280x720"s, - "1920x1080"s, - "2560x1080"s, - "2560x1440"s, - "3440x1440"s, - "1920x1200"s, - "3840x2160"s, - "3840x1600"s, - }, // supported resolutions - - { 10, 30, 60, 90, 120 }, // supported fps }; input_t input { @@ -1044,8 +1029,6 @@ namespace config { path_f(vars, "credentials_file", config::sunshine.credentials_file); string_f(vars, "external_ip", nvhttp.external_ip); - list_string_f(vars, "resolutions"s, nvhttp.resolutions); - list_int_f(vars, "fps"s, nvhttp.fps); list_prep_cmd_f(vars, "global_prep_cmd", config::sunshine.prep_cmds); string_f(vars, "audio_sink", audio.sink); diff --git a/src/config.h b/src/config.h index d2c4783c..c987fc54 100644 --- a/src/config.h +++ b/src/config.h @@ -115,8 +115,6 @@ namespace config { std::string file_state; std::string external_ip; - std::vector resolutions; - std::vector fps; }; struct input_t { diff --git a/src/nvhttp.cpp b/src/nvhttp.cpp index af32391b..085402ff 100644 --- a/src/nvhttp.cpp +++ b/src/nvhttp.cpp @@ -734,31 +734,6 @@ namespace nvhttp { } tree.put("root.ServerCodecModeSupport", codec_mode_flags); - pt::ptree display_nodes; - for (auto &resolution : config::nvhttp.resolutions) { - auto pred = [](auto ch) { return ch == ' ' || ch == '\t' || ch == 'x'; }; - - auto middle = std::find_if(std::begin(resolution), std::end(resolution), pred); - if (middle == std::end(resolution)) { - BOOST_LOG(warning) << resolution << " is not in the proper format for a resolution: WIDTHxHEIGHT"sv; - continue; - } - - auto width = util::from_chars(&*std::begin(resolution), &*middle); - auto height = util::from_chars(&*(middle + 1), &*std::end(resolution)); - for (auto fps : config::nvhttp.fps) { - pt::ptree display_node; - display_node.put("Width", width); - display_node.put("Height", height); - display_node.put("RefreshRate", fps); - - display_nodes.add_child("DisplayMode", display_node); - } - } - - if (!config::nvhttp.resolutions.empty()) { - tree.add_child("root.SupportedDisplayMode", display_nodes); - } auto current_appid = proc::proc.running(); tree.put("root.PairStatus", pair_status); tree.put("root.currentgame", current_appid); diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index 8c2bce2b..8386dbd3 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -49,8 +49,6 @@ v-if="currentTab === 'av'" :config="config" :platform="platform" - :resolutions="resolutions" - :fps="fps" > @@ -128,8 +126,6 @@ saved: false, restarted: false, config: null, - fps: [], - resolutions: [], currentTab: "general", global_prep_cmd: [], tabs: [ // TODO: Move the options to each Component instead, encapsulate. @@ -174,8 +170,6 @@ "install_steam_audio_drivers": "enabled", "adapter_name": "", "output_name": "", - "resolutions": "[352x240,480x360,858x480,1280x720,1920x1080,2560x1080,2560x1440,3440x1440,1920x1200,3840x2160,3840x1600]", - "fps": "[10,30,60,90,120]", "min_fps_factor": 1, }, }, @@ -320,16 +314,6 @@ }); }); - this.fps = JSON.parse(this.config.fps); - //Resolutions should be fixed because are not valid JSON - let res = this.config.resolutions.substring( - 1, - this.config.resolutions.length - 1 - ); - let resolutions = []; - res.split(",").forEach((r) => resolutions.push(r.trim())); - this.resolutions = resolutions; - this.config.global_prep_cmd = this.config.global_prep_cmd || []; this.global_prep_cmd = JSON.parse(this.config.global_prep_cmd); }); @@ -339,16 +323,6 @@ this.$forceUpdate() }, serialize() { - let nl = this.config === "windows" ? "\r\n" : "\n"; - this.config.resolutions = - "[" + - nl + - " " + - this.resolutions.join("," + nl + " ") + - nl + - "]"; - // remove quotes from values in fps - this.config.fps = JSON.stringify(this.fps).replace(/"/g, ""); this.config.global_prep_cmd = JSON.stringify(this.global_prep_cmd); }, save() { @@ -364,19 +338,11 @@ Object.keys(tab.options).forEach(optionKey => { let delete_value = false - if (["resolutions", "fps", "global_prep_cmd"].includes(optionKey)) { + if (["global_prep_cmd"].includes(optionKey)) { let config_value, default_value - if (optionKey === "resolutions") { - let regex = /([\d]+x[\d]+)/g - - // Use a regular expression to find each value and replace it with a quoted version - config_value = JSON.parse(config[optionKey].replace(regex, '"$1"')).toString() - default_value = JSON.parse(tab.options[optionKey].replace(regex, '"$1"')).toString() - } else { - config_value = JSON.parse(config[optionKey]) - default_value = JSON.parse(tab.options[optionKey]) - } + config_value = JSON.parse(config[optionKey]) + default_value = JSON.parse(tab.options[optionKey]) if (config_value === default_value) { delete_value = true diff --git a/src_assets/common/assets/web/configs/tabs/AudioVideo.vue b/src_assets/common/assets/web/configs/tabs/AudioVideo.vue index 1a5b63c0..21160dfe 100644 --- a/src_assets/common/assets/web/configs/tabs/AudioVideo.vue +++ b/src_assets/common/assets/web/configs/tabs/AudioVideo.vue @@ -11,8 +11,6 @@ import DisplayModesSettings from "./audiovideo/DisplayModesSettings.vue"; const props = defineProps([ 'platform', 'config', - 'resolutions', - 'fps', 'min_fps_factor', ]) @@ -82,8 +80,6 @@ const config = ref(props.config) diff --git a/src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue b/src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue index d519d75f..b901e1ca 100644 --- a/src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue +++ b/src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue @@ -6,14 +6,10 @@ import PlatformLayout from '../../../PlatformLayout.vue' const props = defineProps([ 'platform', 'config', - 'resolutions', - 'fps', 'min_fps_factor', ]) const config = ref(props.config) -const resolutions = ref(props.resolutions) -const fps = ref(props.fps) const resIn = ref("") const fpsIn = ref("") @@ -21,50 +17,6 @@ const fpsIn = ref("")