From 25e0244705b6e544a185e2286874884299f0e43e Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Mon, 15 May 2023 18:29:56 -0500 Subject: [PATCH] Stop reporting ExternalIP field to clients At best, it doesn't help compared to Moonlight's STUN logic. At worst, it makes things worse by providing an incorrect WAN address that overrides STUN. --- src/nvhttp.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/nvhttp.cpp b/src/nvhttp.cpp index 4a34f280..dfa0b9fe 100644 --- a/src/nvhttp.cpp +++ b/src/nvhttp.cpp @@ -632,10 +632,6 @@ namespace nvhttp { tree.put("root.ServerCodecModeSupport", "3"); } - if (!config::nvhttp.external_ip.empty()) { - tree.put("root.ExternalIP", config::nvhttp.external_ip); - } - pt::ptree display_nodes; for (auto &resolution : config::nvhttp.resolutions) { auto pred = [](auto ch) { return ch == ' ' || ch == '\t' || ch == 'x'; };