izackp/Apollo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pessimizing move warnings on Clang

Browse Source
This commit is contained in:
Cameron Gutman
2023-05-11 00:07:34 -05:00
parent 8db0ad0cc6
commit 2571682886
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/config.cpp
+1 -4
View File
@@ -832,10 +832,7 @@ namespace config {
auto undo_cmd = prep_cmd.get_optional<std::string>("undo"s); auto undo_cmd = prep_cmd.get_optional<std::string>("undo"s);
auto elevated = prep_cmd.get_optional<bool>("elevated"s); auto elevated = prep_cmd.get_optional<bool>("elevated"s);
input.emplace_back( input.emplace_back(do_cmd.value_or(""), undo_cmd.value_or(""), elevated.value_or(false));
std::move(do_cmd.value_or("")),
std::move(undo_cmd.value_or("")),
std::move(elevated.value_or(false)));
} }
} }
src/stream.cpp
+4 -4
View File
@@ -1475,8 +1475,8 @@ namespace stream {
// Enable QoS tagging on video traffic if requested by the client // Enable QoS tagging on video traffic if requested by the client
if (session->config.videoQosType) { if (session->config.videoQosType) {
auto address = session->video.peer.address(); auto address = session->video.peer.address();
session->video.qos = std::move(platf::enable_socket_qos(ref->video_sock.native_handle(), address, session->video.qos = platf::enable_socket_qos(ref->video_sock.native_handle(), address,
session->video.peer.port(), platf::qos_data_type_e::video)); session->video.peer.port(), platf::qos_data_type_e::video);
} }
BOOST_LOG(debug) << "Start capturing Video"sv; BOOST_LOG(debug) << "Start capturing Video"sv;
@@ -1500,8 +1500,8 @@ namespace stream {
// Enable QoS tagging on audio traffic if requested by the client // Enable QoS tagging on audio traffic if requested by the client
if (session->config.audioQosType) { if (session->config.audioQosType) {
auto address = session->audio.peer.address(); auto address = session->audio.peer.address();
session->audio.qos = std::move(platf::enable_socket_qos(ref->audio_sock.native_handle(), address, session->audio.qos = platf::enable_socket_qos(ref->audio_sock.native_handle(), address,
session->audio.peer.port(), platf::qos_data_type_e::audio)); session->audio.peer.port(), platf::qos_data_type_e::audio);
} }
BOOST_LOG(debug) << "Start capturing Audio"sv; BOOST_LOG(debug) << "Start capturing Audio"sv;